Review main Merged

88763[TASK] Remove `FormEngineValidation.pol()`

Andreas Kienast CR +2 V +2 Easy +1 −7 updated 03/26/25, 08:21

Commit message

The FormEngineValidation sub-module has a method `pol()` that aims to
interpolate any string value, under the assumption it's always an
integer, by using `eval()`, which is bad by design – there would've
been better ways to do this.

The method is unused since TYPO3 v11 and a TER code search didn't
reveal usage, therefore the code is removed.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Andreas Kienast uploaded patch set 1 03/26/25, 07:06

  2. core-ci voted on patch set 1 V +1 03/26/25, 07:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76347

  3. Andreas Kienast uploaded patch set 2 V +1 03/26/25, 07:39

  4. core-ci voted on patch set 2 V +1 03/26/25, 07:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76354

  5. Georg Ringer voted on patch set 2 CR +1 V +1 03/26/25, 07:57

  6. Benni Mack voted on patch set 2 CR +1 V +1 03/26/25, 08:20

  7. Andreas Kienast voted on patch set 2 CR +2 V +2 03/26/25, 08:20

  8. Andreas Kienast merged patch set 3 03/26/25, 08:21