88774[BUGFIX] Render selected icon pane when at least one item has an icon
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1725
-
Stefan Bürk uploaded patch set 1 03/26/25, 13:41
-
Stefan Bürk updated the commit message in patch set 2 03/26/25, 13:46
-
core-ci voted on patch set 1 V +1 03/26/25, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76383
-
core-ci voted on patch set 2 V +1 03/26/25, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76384
-
Garvin Hicking commented on patch set 3
V +103/26/25, 17:41Published edit on patch set 2. -
core-ci voted on patch set 3 V +1 03/26/25, 17:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76395
-
Garvin Hicking updated the commit message in patch set 4
V +103/26/25, 18:01 -
core-ci voted on patch set 4 V +1 03/26/25, 18:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76397
-
Garvin Hicking uploaded patch set 5
V +103/26/25, 18:29 -
Garvin Hicking commented on patch set 5 V -1 03/26/25, 18:35
That's a good catch. I believe this patch has a problem still. I added a styleguide example to easily test this. Check out select_single_22 and select_single_23 - the icon bar below does not list the entries without icons, and I would expect the items to show up with a "missing icon" prefix instead? Also, a selected item without an icon shows up with the broken image. If I switch to an icon, and then back to the itemless item, it will show an empty box instead of the 'missing icon' image (which I would expect). So I wonder if we should alter this patch to both: - When selecting an item with a missing icon, re-insert the "missing icon" placeholder in the select box placeholder (I believe the javascript does this) - insert a "missing icon" in the icon chooser pane so that values can be selected which do not have an icon What do you think? -
Garvin Hicking commented on patch set 5 03/26/25, 18:35
tx_styleguide_elements_select.php:330Note this is intentionally "broken" to see have one case that can distinguish between "no image" and "broken image". -
core-ci voted on patch set 5 V +1 03/26/25, 18:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76399
-
Stefan Bürk updated the commit message in patch set 6
V +103/26/25, 20:20 -
Stefan Bürk voted on patch set 6 CR -1 03/26/25, 20:20
-
Stefan Bürk commented on patch set 6 03/26/25, 20:23
Reply
What you mention is the fieldWizard added additionally, did not had that in view. Need to reconsider/think about that and will work/push something on top of that. Came back to reviwe that because during a walk in fresh air it bubbled up that the solution has another flaw beside what you mentioned. Thanks for looking into it and providing it as styleguide test. I did that with CType and adding a ctype plugin without an icon (had a extension locally laying around). Set to wip prefix and working on it. -
core-ci voted on patch set 6 V +1 03/26/25, 20:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76402
-
Stefan Bürk uploaded patch set 7
CR -1V +103/27/25, 09:42 -
Stefan Bürk commented on patch set 7 03/27/25, 09:46
Reply
Looking into it again, it revealed even more. I adjusted the change, concentrating on: * decide displaying the pane on the fact when at least one item has an icon * ensure the first group item icon fallback is only when no item is selected, and not when the selected item has no icon. Which means, that items without icons displays no icon in the box left of the select box (staying empty) and are not selectable in the fieldWizard (bottom bar) like it is until now. I'd say that this needs a general UX decicision how to deal with it and how to determine a correct icon or making items without icon selectable in the field wizard and should not be done as a quick bugfix. The aim of this bugfix is and should stay to ensure that the pane is display when at least one item has an icon and is not hidden when the last item (of the last group) has no icon set and hiding it for all items. Not perfect, but improves the overall situation slightly. -
Stefan Bürk uploaded patch set 8 03/27/25, 09:49
-
Stefan Bürk commented on patch set 7 03/27/25, 09:50
tx_styleguide_elements_select.php:330ReplyAdded as comment in the TCA file. -
core-ci voted on patch set 7 V +1 03/27/25, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76428
-
core-ci voted on patch set 8 V +1 03/27/25, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76429
-
Benni Mack voted on patch set 8 CR +1 V +1 03/27/25, 14:21
-
Georg Ringer voted on patch set 8 CR +2 V +2 03/27/25, 16:06
-
Georg Ringer merged patch set 9 03/27/25, 16:06