Review main Merged

88782[TASK] Use AssetCollector for backend modules

Benjamin Franzke CR +2 V +2 Hard +279 −456 updated 04/10/25, 14:07

Commit message

Use AssetCollector API for backend JavaScript modules and CSS resources
as a first attempt to streamline frontend and backend asset registration
in order to streamline developer experience towards one unified asset
registration interface.

The now unused `<f:be.pageRenderer>` view helper arguments
`includeJavaScriptModules` and `includeCssFiles` are not deprecated yet.
The intent is to deprecate the entire `<f:be.pageRenderer>` view helper
in one step once there is a replacement for `addJsInlineLabels` as well.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 81

Show 61 more files

Review log 1318

  1. Benjamin Franzke uploaded patch set 1 03/26/25, 20:44

  2. core-ci voted on patch set 1 V -1 03/26/25, 20:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76404

  3. Benjamin Franzke uploaded patch set 2 V -1 03/26/25, 21:39

  4. core-ci voted on patch set 2 V +1 03/26/25, 21:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76406

  5. Benjamin Franzke uploaded patch set 3 V +1 03/26/25, 22:19

  6. core-ci voted on patch set 3 V +1 03/26/25, 22:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76407

  7. Benni Mack commented on patch set 3 04/09/25, 17:16

    See https://review.typo3.org/c/Packages/TYPO3.CMS/+/87224 that fixes cache busting and explains why it did not work - the related issue in that one
  8. Benjamin Franzke uploaded patch set 4 V +1 04/10/25, 05:53

  9. Benjamin Franzke commented on patch set 4 04/10/25, 05:53

    Reply

    Thx, although I do not agreee with all details of that patch (js compression is another story), it contains the same fix for css cache busting, that I applied inhere as well. Rebased, thx.
  10. core-ci voted on patch set 4 V +1 04/10/25, 06:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77384

  11. Benjamin Franzke uploaded patch set 5 V +1 04/10/25, 06:49

  12. core-ci voted on patch set 5 V +1 04/10/25, 06:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77387

  13. Benjamin Franzke marked it ready for review 04/10/25, 08:48

  14. Benni Mack voted on patch set 5 CR +1 V +1 04/10/25, 09:34

  15. Georg Ringer voted on patch set 5 CR +1 V +1 04/10/25, 09:46

  16. Stefan Bürk voted on patch set 5 CR +1 V +1 04/10/25, 13:02

  17. Benjamin Franzke voted on patch set 5 CR +2 V +2 04/10/25, 14:06

  18. Benjamin Franzke merged patch set 6 04/10/25, 14:07