88785[BUGFIX] Treat 0 as a defined value for nullable datetime fields
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
-
Verified V +2 Done
- Benjamin Franzke +2
- core-ci +1 CI
Issues 2
Files 13
- Build/phpstan/phpstan-baseline.neon+0 −6
- Build/Sources/TypeScript/backend/tests/form-engine-validation-test.ts+0 −24
- Build/Sources/TypeScript/backend/form-engine-validation.ts+1 −2
- typo3/sysext/backend/Classes/Form/Element/DatetimeElement.php+22 −20
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-validation.js+1 −1
- typo3/sysext/core/Classes/Database/Schema/DefaultTcaSchema.php+1 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+5 −4
- typo3/sysext/core/Documentation/Changelog/13.4.x/Important-106401-Treat0AsADefinedValueForNullableDatetimeFields.rstnew+59 −0
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsBasicInputDateCest.php+19 −3
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeDatetimeNullableRange.phpnew+45 −0
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGeneratorInterface.php+1 −1
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_elements_basic.php+13 −5
- typo3/sysext/styleguide/Configuration/Services.yaml+1 −0
Review log 68
-
Benjamin Franzke commented on patch set 1 03/27/25, 07:27
Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Resources/Public/JavaScript/form-engine-validation.js -
core-ci voted on patch set 1 V -1 03/27/25, 07:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76426
-
Benjamin Franzke uploaded patch set 2
V -103/27/25, 09:59 -
core-ci voted on patch set 2 V +1 03/27/25, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76430
-
Benjamin Franzke marked it ready for review 03/27/25, 10:14
-
Benjamin Franzke merged patch set 3 03/27/25, 10:15
-
Lina Wolf commented on patch set 3 03/29/25, 07:00
Please review related docs:https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-TCA/pull/1236 -
Benjamin Franzke commented on patch set 3 03/29/25, 09:35
Reply
Thanks, approved!