Review 13.4 Merged

88785[BUGFIX] Treat 0 as a defined value for nullable datetime fields

Benjamin Franzke CR +2 V +2 Normal +168 −67 updated 03/29/25, 09:35

Commit message

For a nullable integer based datetime field the value `0` refers to the
unix epoch time (1970-01-01T00:00:00Z), only an explicit `null` database
value shall be considered an empty value.

This makes workarounds that combine default=0 and range.lower conditions
superfluous and invalid, since `default=0` does not mean empty for a
nullable field, but "unix epoch time".

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 13

Review log 68

  1. Benjamin Franzke commented on patch set 1 03/27/25, 07:27

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Resources/Public/JavaScript/form-engine-validation.js
  2. core-ci voted on patch set 1 V -1 03/27/25, 07:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76426

  3. Benjamin Franzke uploaded patch set 2 V -1 03/27/25, 09:59

  4. core-ci voted on patch set 2 V +1 03/27/25, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76430

  5. Benjamin Franzke marked it ready for review 03/27/25, 10:14

  6. Benjamin Franzke merged patch set 3 03/27/25, 10:15

  7. Lina Wolf commented on patch set 3 03/29/25, 07:00

  8. Benjamin Franzke commented on patch set 3 03/29/25, 09:35

    Reply

    Thanks, approved!