Review main Merged

88786[BUGFIX] Fallback to placeholder on missing icon in workspace table

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 04/01/25, 13:14

Commit message

If a new root page is created in a workspace, it may lack a site
configuation. This leads to the situation that an icon is attempted to
be considered for the default language, which fails as there is no
configuration, yet.

The code responsible for the failing call is even declared to return
null values, which wasn't detected by phpstan (probably due to a too low
level). In case such language icon cannot be determined, an empty
placeholder icon is now used.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Thomas Hohn +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Andreas Kienast uploaded patch set 1 03/27/25, 08:12

  2. core-ci voted on patch set 1 V +1 03/27/25, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76427

  3. Thomas Hohn voted on patch set 1 CR +1 03/27/25, 10:08

  4. Benni Mack commented on patch set 1 CR +1 V +1 03/28/25, 13:56

    weird setup
  5. Stefan Bürk voted on patch set 1 CR +1 V +1 04/01/25, 12:45

  6. Andreas Kienast voted on patch set 1 CR +2 V +2 04/01/25, 12:50

  7. Andreas Kienast merged patch set 2 04/01/25, 13:14