88789[TASK] Deprecate BackendUtility::resolveFileReferences
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+5 −0
- typo3/sysext/backend/Tests/Unit/Utility/BackendUtilityTest.php+0 −82
- typo3/sysext/core/Documentation/Changelog/14.0/Deprecation-106393-VariousMethodsInBackendUtility.rst+12 −2
- typo3/sysext/workspaces/Classes/Controller/Remote/RemoteServer.php6+79 −12
- typo3/sysext/workspaces/Tests/Unit/Controller/Remote/RemoteServerTest.php2+33 −0
Review log 1418
-
Georg Ringer uploaded patch set 1 03/27/25, 10:16
-
Georg Ringer commented on patch set 1 03/27/25, 10:16
This change is ready for review. -
Benni Mack commented on patch set 1 03/27/25, 10:20
RemoteServer.php:473Actually, EXT:workspaces uses Schema API instead of this. You can hand in $fieldInformation into the method... -
core-ci voted on patch set 1 V -1 03/27/25, 10:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76433
-
Georg Ringer commented on patch set 2
V -103/27/25, 10:42Published edit on patch set 1. -
core-ci voted on patch set 2 V +1 03/27/25, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76437
-
Simon Schaufelberger commented on patch set 2 03/27/25, 17:52
RemoteServer.php:501no dockbock style here pleaseRemoteServer.php:506no dockbock style here pleaseRemoteServerTest.php:208lolli don't like empty lines 😄 -
Simon Schaufelberger uploaded patch set 3
V +103/27/25, 21:14 -
Simon Schaufelberger commented on patch set 2 03/27/25, 21:14
RemoteServer.php:501ReplyDoneRemoteServer.php:506ReplyDoneRemoteServerTest.php:208ReplyDone -
Simon Schaufelberger commented on patch set 3 03/27/25, 21:14
RemoteServer.php:473ReplyDone -
core-ci voted on patch set 3 V +1 03/27/25, 21:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76513
-
Simon Schaufelberger uploaded patch set 4
V +103/27/25, 21:28 -
core-ci voted on patch set 4 V +1 03/27/25, 21:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76518
-
Simon Schaufelberger voted on patch set 4 CR +1 V +1 03/27/25, 22:20
-
Benni Mack voted on patch set 4 CR +2 V +2 03/27/25, 22:21
-
Benni Mack merged patch set 5 03/27/25, 22:21
-
Stefan Bürk commented on patch set 5 03/27/25, 22:25
post -1. Tests for depreecated methods should not removed, working state needs still to be ensured until the method(s) are removed with TYPO3 v15. Instead the PHP Attribute `#[IgnoreDeprecations]` should have been added. -
Benni Mack commented on patch set 5 03/27/25, 22:26
Reply Unresolved
you are right, will do in a followup