Review main Merged

88789[TASK] Deprecate BackendUtility::resolveFileReferences

Georg Ringer CR +2 V +2 Normal +129 −96 updated 03/27/25, 22:26

Commit message

Move the only usage of BackendUtility::resolveFileReferences and
deprecate it.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1418

  1. Georg Ringer uploaded patch set 1 03/27/25, 10:16

  2. Georg Ringer commented on patch set 1 03/27/25, 10:16

    This change is ready for review.
  3. Benni Mack commented on patch set 1 03/27/25, 10:20

    RemoteServer.php:473

    Actually, EXT:workspaces uses Schema API instead of this. You can hand in $fieldInformation into the method...
  4. core-ci voted on patch set 1 V -1 03/27/25, 10:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76433

  5. Georg Ringer commented on patch set 2 V -1 03/27/25, 10:42

    Published edit on patch set 1.
  6. core-ci voted on patch set 2 V +1 03/27/25, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76437

  7. Simon Schaufelberger commented on patch set 2 03/27/25, 17:52

    RemoteServer.php:501

    no dockbock style here please

    RemoteServer.php:506

    no dockbock style here please

    RemoteServerTest.php:208

    lolli don't like empty lines 😄
  8. Simon Schaufelberger uploaded patch set 3 V +1 03/27/25, 21:14

  9. Simon Schaufelberger commented on patch set 2 03/27/25, 21:14

    RemoteServer.php:501 Reply

    Done

    RemoteServer.php:506 Reply

    Done

    RemoteServerTest.php:208 Reply

    Done
  10. Simon Schaufelberger commented on patch set 3 03/27/25, 21:14

    RemoteServer.php:473 Reply

    Done
  11. core-ci voted on patch set 3 V +1 03/27/25, 21:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76513

  12. Simon Schaufelberger uploaded patch set 4 V +1 03/27/25, 21:28

  13. core-ci voted on patch set 4 V +1 03/27/25, 21:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76518

  14. Simon Schaufelberger voted on patch set 4 CR +1 V +1 03/27/25, 22:20

  15. Benni Mack voted on patch set 4 CR +2 V +2 03/27/25, 22:21

  16. Benni Mack merged patch set 5 03/27/25, 22:21

  17. Stefan Bürk commented on patch set 5 03/27/25, 22:25

    post -1. Tests for depreecated methods should not removed, working state needs still to be ensured until the method(s) are removed with TYPO3 v15. Instead the PHP Attribute `#[IgnoreDeprecations]` should have been added.
  18. Benni Mack commented on patch set 5 03/27/25, 22:26

    Reply Unresolved

    you are right, will do in a followup