Review main Merged

88791[BUGFIX] Only append "(Copy 2)" when configured

Benni Mack CR +2 V +2 Easy +5 −2 updated 04/08/25, 11:54

Commit message

DataHandler checks for $GLOBALS['TCA'][$table]['ctrl']['prependAtCopy']
on copy. If this is empty, the call is executed a lot of times to add
"(Copy)", resulting in a lot of calls to the DB.

This change adds the recursive call to the DB only if the property is
set correctly.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Benni Mack uploaded patch set 1 03/27/25, 10:39

  2. Benni Mack marked it work in progress 03/27/25, 10:39

  3. core-ci voted on patch set 1 V +1 03/27/25, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76436

  4. Benni Mack marked it ready for review 03/27/25, 11:04

  5. Benni Mack marked it work in progress 03/27/25, 11:04

  6. Christian Kuhn uploaded patch set 2 V +1 04/08/25, 11:17

  7. Christian Kuhn commented on patch set 2 CR +1 V +1 04/08/25, 11:17

    This change is ready for review.
  8. core-ci voted on patch set 2 V +1 04/08/25, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77199

  9. Simon Schaufelberger voted on patch set 2 CR +1 V +1 04/08/25, 11:28

  10. Christian Kuhn voted on patch set 2 CR +2 V +2 04/08/25, 11:53

  11. Christian Kuhn merged patch set 3 04/08/25, 11:54