Review 12.4 Merged

88809[BUGFIX] ADMCMD_* params missing for split preview URLs

Benni Mack CR +2 V +2 Easy +43 −6 updated 03/28/25, 07:36

Commit message

This makes sure the two iframe URLs of the workspace split preview
contain the necessary GET parameters:

* ADMCMD_simUser
* ADMCMD_simTime

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Johannes Kasberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Johannes Kasberger +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 79

  1. Benni Mack commented on patch set 1 03/27/25, 20:41

    Cherry Picked from branch 13.4. The following files contain Git conflicts: * typo3/sysext/workspaces/Classes/Controller/PreviewController.php
  2. Benni Mack uploaded patch set 2 03/27/25, 20:45

  3. Benni Mack marked it ready for review 03/27/25, 20:45

  4. core-ci voted on patch set 2 V +1 03/27/25, 20:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76510

  5. core-ci voted on patch set 1 V -1 03/27/25, 21:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76509

  6. Markus Klein commented on patch set 2 CR +1 V +1 03/28/25, 07:30

    Thanks!
  7. Johannes Kasberger voted on patch set 2 CR +1 V +1 03/28/25, 07:31

  8. Benni Mack voted on patch set 2 CR +2 V +2 03/28/25, 07:36

  9. Benni Mack merged patch set 3 03/28/25, 07:36