Review main Merged

88815[BUGFIX] Respect long titles in inline headers

Christian Huppert CR +2 V +2 Easy +3 −1 updated 04/09/25, 13:29

Commit message

Even if the title of a file is long, the layout must be kept in place.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2128

Show 23 earlier messages
  1. Christian Huppert uploaded patch set 1 03/27/25, 23:43

  2. core-ci voted on patch set 1 V -1 03/27/25, 23:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76527

  3. Christian Huppert uploaded patch set 2 V -1 03/28/25, 00:01

  1. core-ci voted on patch set 2 V -1 03/28/25, 00:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76528

  2. Christian Huppert uploaded patch set 3 V -1 03/28/25, 00:06

  3. Christian Huppert uploaded patch set 4 03/28/25, 00:10

  4. core-ci voted on patch set 3 V +1 03/28/25, 00:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76529

  5. core-ci voted on patch set 4 V -1 03/28/25, 00:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76530

  6. Christian Huppert uploaded patch set 5 V -1 03/28/25, 01:12

  7. core-ci voted on patch set 5 V +1 03/28/25, 01:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76532

  8. Markus Klein commented on patch set 5 03/28/25, 06:31

    Should this only be fixed in main? Issue was reported for v12.
  9. Georg Ringer updated the commit message in patch set 6 V +1 03/28/25, 07:07

  10. core-ci voted on patch set 6 V +1 03/28/25, 07:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76551

  11. Christian Huppert commented on patch set 6 03/28/25, 16:44

    Reply

    Thanks, Markus, for your comment. The fix can also be applied in v13 as I just verified. The fix can be also applied in v12 but needs an extra step. The thing though for v12 is that the regular maintenance phase for v12 has run out by 31/10/24 (see [1]). Only priority bugfixes are done for v12, so security and critical fixes as explained in [2]. So I think that we can ignore the fix for v12, what do you think? You can also write me a DM in Slack and I am happy to clarify the open questions with you. [1] https://typo3.org/cms/roadmap [2] https://stackoverflow.com/a/56578337
  12. Garvin Hicking voted on patch set 6 V +1 03/31/25, 08:35

  13. Andreas Kienast commented on patch set 6 03/31/25, 18:03

    I just read the, didn‘t test it, yet: how does the controls behave in small viewports and rtl mode?
  14. Georg Ringer commented on patch set 6 CR +1 V +1 03/31/25, 19:01

    @akienast@scripting-base.de i attached 2 screenshots in the issue. RTL seems fine when testing with "chrome://flags/#force-ui-direction"
  15. Andreas Kienast commented on patch set 6 V -1 04/01/25, 07:47

    I set my backend to Arabic, which sets the whole backend into RTL mode. As assumed, the buttons are now positioned over the text.
  16. Andreas Kienast uploaded patch set 7 CR +1 V +1 04/01/25, 07:55

  17. Andreas Kienast commented on patch set 7 04/01/25, 07:56

    Reply

    Done
  18. core-ci voted on patch set 7 V +1 04/01/25, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76759

  19. Georg Ringer voted on patch set 7 CR +1 V +1 04/01/25, 08:30

  20. Garvin Hicking commented on patch set 7 CR +1 V +1 04/01/25, 09:38

    Reply

    Done
  21. Georg Ringer voted on patch set 7 CR +2 V +2 04/01/25, 11:23

  22. Georg Ringer merged patch set 8 04/01/25, 11:23

  23. Christian Huppert commented on patch set 8 04/01/25, 12:20

    Reply

    Thanks, Andreas for checking and correcting my patch. Indeed I had not on my radar the rtl mode though I know that it is possible since v13. In small viewports in ltr mode the buttons were positioned correctly when the page tree is collapsed. I think it is acceptable that they are not correctly positioned if the page tree is visible/uncollapsed as on mobile one cannot edit the content in a content element if the page tree is visible. I mean in that case the editor will collapse the page tree in order they can edit the content. What do you think about this? Kind regards, Christian
  24. Andreas Kienast wrote 04/09/25, 13:29

    Created a revert of this change as I172ccf0e7a74ff1638b0bf99622b5950623fab29
  25. Benjamin Kott commented on patch set 8 04/09/25, 13:29

    post -1 needs revert - wrong approach. 1. this collapses the inline display of irre elements 2. misuse of absolute position that removes the controls from the document flow.