Review main Merged

88820[BUGFIX] Detect mount points as subpages in menus

Georg Ringer CR +2 V +2 Normal +88 −3 updated 10/22/26, 16:47

Commit message

A page whose children are all mount points in overlay mode was
rendered as having no subpages: the IFSUB item states stayed
inactive and the submenu was dropped entirely. Adding a single
ordinary sibling next to the mount points made both work again.

isSubMenu() fetches the children of all pages of the current level
in one query and assigns them to their parent by comparing pid to
the parent uid. A mount point in overlay mode has been replaced by
the mounted page at that point, and that record lives elsewhere in
the page tree, so it is assigned to no parent at all.
prepareMenuItems() then reuses the cached negative decision and
skips the submenu query, which is why the children vanish as well.

PageRepository now keeps the parent a mount point was found below
in _MOUNT_POINT_ORIGINAL_PAGE_PID, and isSubMenu() prefers it over
the pid. The single query per menu level is kept.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 68

  1. Georg Ringer uploaded patch set 1 03/28/25, 09:21

  2. core-ci voted on patch set 1 V +1 03/28/25, 09:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76559

  3. Georg Ringer uploaded patch set 2 V +1 09/17/26, 19:14

  4. Georg Ringer commented on patch set 2 09/17/26, 19:15

    This change is ready for review.
  5. core-ci voted on patch set 2 V +1 09/17/26, 19:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108763

  6. Simon Schaufelberger voted on patch set 2 CR +1 V +1 09/17/26, 22:41

  7. Benni Mack commented on patch set 2 CR +2 V +2 10/22/26, 15:57

    not a fan of this solution, but OK.
  8. Benni Mack merged patch set 3 10/22/26, 16:47