88823[BUGFIX] Apply server timezone to datetime properties in record API
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 8
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseRowDateTimeFields.php2+8 −37
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseRowDateTimeFieldsTest.php+3 −3
- typo3/sysext/core/Classes/DataHandling/RecordFieldTransformer.php+2 −4
- typo3/sysext/core/Classes/Domain/DateTimeFactory.php3new+143 −0
- typo3/sysext/core/Classes/Schema/Field/DateTimeFieldType.php+18 −2
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsBasicInputDateCest.php+8 −16
- typo3/sysext/core/Tests/Functional/DataHandling/RecordFieldTransformerTest.php+34 −9
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_relation_resolver/Configuration/TCA/Overrides/tt_content.php+2 −2
Review log 1825
-
Benjamin Franzke uploaded patch set 1 03/28/25, 11:27
-
core-ci voted on patch set 1 V -1 03/28/25, 11:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76571
-
Benjamin Franzke uploaded patch set 2
V -103/28/25, 11:58 -
core-ci voted on patch set 2 V +1 03/28/25, 12:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76576
-
Benjamin Franzke uploaded patch set 3
V +103/28/25, 13:27 -
core-ci voted on patch set 3 V +1 03/28/25, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76591
-
Benjamin Franzke uploaded patch set 4
V +103/28/25, 15:30 -
core-ci voted on patch set 4 V +1 03/28/25, 15:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76599
-
Benjamin Franzke marked it work in progress 03/29/25, 09:35
-
Benjamin Franzke uploaded patch set 5
V +103/29/25, 12:55 -
core-ci voted on patch set 5 V -1 03/29/25, 13:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76635
-
Benjamin Franzke uploaded patch set 6
V -103/29/25, 13:24 -
core-ci voted on patch set 6 V +1 03/29/25, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76639
-
Benjamin Franzke marked it ready for review 03/30/25, 18:54
-
Benni Mack voted on patch set 6 CR +1 V +1 03/31/25, 15:32
-
Andreas Kienast commented on patch set 6 04/01/25, 06:55
DateTimeFactory.php:55This is bascially the same code as in `typo3/sysext/core/Classes/Schema/Field/DateTimeFieldType.php->getFormat()`. Should we consolidate this? -
Benjamin Franzke commented on patch set 6 04/01/25, 10:52
DateTimeFactory.php:55ReplyThought about this, but since `DateTimeFieldType` is the "new" API which is to constructed (only) inside the schema API, I didn't want to reuse that here. The other alternative would have been to call into `getFormatFromTCAConfig` from `DateTimeFieldType.php->getFormat`, but then again `Schema/Field/DateTimeFieldType` can not reuse it's persistenceType logic, and has to call into "legacy" API. -
Andreas Kienast commented on patch set 6 04/01/25, 10:57
DateTimeFactory.php:55ReplyAcknowledged -
Benjamin Franzke uploaded patch set 7
CR +1V +104/01/25, 10:59 -
Benjamin Franzke commented on patch set 7 04/01/25, 10:59
DatabaseRowDateTimeFields.php:36ReplyThanks, done! -
core-ci voted on patch set 7 V +1 04/01/25, 11:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76769
-
Andreas Kienast voted on patch set 7 CR +1 V +1 04/02/25, 07:09
-
Benni Mack voted on patch set 7 CR +1 V +1 04/02/25, 07:39
-
Benjamin Franzke voted on patch set 7 CR +2 V +2 04/02/25, 08:16
-
Benjamin Franzke merged patch set 8 04/02/25, 10:38
DatabaseRowDateTimeFields.php:36