88825[BUGFIX] Check if type param is a scalar value
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1012
-
Georg Ringer uploaded patch set 1 03/28/25, 12:19
-
Georg Ringer commented on patch set 1 03/28/25, 12:20
This change is ready for review. -
Simon Schaufelberger updated the commit message in patch set 2 03/28/25, 12:21
-
Simon Schaufelberger commented on patch set 2 03/28/25, 12:24
PageRouter.php:565UnresolvedI ask myself how people can even pass an array here as type is an internal TYPO3 parameter and can only handle one value? -
core-ci voted on patch set 1 V +1 03/28/25, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76581
-
core-ci voted on patch set 2 V +1 03/28/25, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76582
-
Benni Mack commented on patch set 2 CR -2 03/28/25, 12:35
will have a closer look (with tests) -
Benni Mack commented on patch set 2 03/28/25, 12:35
-
Simon Schaufelberger commented on patch set 2 03/28/25, 12:51
Reply Unresolved
yes, I would prefer your solution that this casting. -
Benni Mack commented on patch set 2 03/28/25, 22:36
Some notes: That is the right place to fix technically. However, I'm all for sanitzing this information at an earlier stage of the Request pipeline, will deal with that separately. Currently, I think we need to add this to PageRouter->matchRequest() to the very first line... I will also add tests to it. -
Benni Mack commented on patch set 2 03/28/25, 22:36
ah, see https://review.typo3.org/c/Packages/TYPO3.CMS/+/86100 which fits properly at the right place -
Georg Ringer abandoned the change 03/30/25, 08:05