Review main Abandoned

88825[BUGFIX] Check if type param is a scalar value

Georg Ringer CR 0 V 0 Easy +1 −1 updated 03/30/25, 08:05

Commit message

Avoid warnings like an array to string conversion by checking the
type.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1012

  1. Georg Ringer uploaded patch set 1 03/28/25, 12:19

  2. Georg Ringer commented on patch set 1 03/28/25, 12:20

    This change is ready for review.
  3. Simon Schaufelberger updated the commit message in patch set 2 03/28/25, 12:21

  4. Simon Schaufelberger commented on patch set 2 03/28/25, 12:24

    PageRouter.php:565 Unresolved

    I ask myself how people can even pass an array here as type is an internal TYPO3 parameter and can only handle one value?
  5. core-ci voted on patch set 1 V +1 03/28/25, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76581

  6. core-ci voted on patch set 2 V +1 03/28/25, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76582

  7. Benni Mack commented on patch set 2 CR -2 03/28/25, 12:35

    will have a closer look (with tests)
  8. Benni Mack commented on patch set 2 03/28/25, 12:35

  9. Simon Schaufelberger commented on patch set 2 03/28/25, 12:51

    Reply Unresolved

    yes, I would prefer your solution that this casting.
  10. Benni Mack commented on patch set 2 03/28/25, 22:36

    Some notes: That is the right place to fix technically. However, I'm all for sanitzing this information at an earlier stage of the Request pipeline, will deal with that separately. Currently, I think we need to add this to PageRouter->matchRequest() to the very first line... I will also add tests to it.
  11. Benni Mack commented on patch set 2 03/28/25, 22:36

    ah, see https://review.typo3.org/c/Packages/TYPO3.CMS/+/86100 which fits properly at the right place
  12. Georg Ringer abandoned the change 03/30/25, 08:05