Review main Merged

88829[FEATURE] Pass TCA config and field name to slug prefix userFunc

Benni Mack CR +2 V +2 Normal +80 −4 updated 02/27/26, 08:54

Commit message

The slug prefix user function now receives the full TCA field
configuration and the field name directly via
`$parameters['config']` and `$parameters['fieldName'].

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1925

  1. Benni Mack uploaded patch set 1 03/28/25, 17:04

  2. core-ci voted on patch set 1 V +1 03/28/25, 17:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76608

  3. Benni Mack commented on patch set 2 V +1 03/28/25, 17:18

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 03/28/25, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76610

  5. Mathias Brodala commented on patch set 2 03/31/25, 07:18

    Ain't this a feature? ;-)
  6. Benni Mack commented on patch set 2 CR -1 03/31/25, 07:23

    good point!
  7. Georg Ringer commented on patch set 2 03/31/25, 07:33

    more a bugfix ^^
  8. Stefan Bürk commented on patch set 2 04/01/25, 13:00

    TcaSlug.php:59

    should we not pass the whole field config instead of only a "subset" ?
  9. Benni Mack marked it work in progress 04/01/25, 13:04

  10. Benni Mack uploaded patch set 3 CR -1 V +1 07/25/25, 09:12

  11. Benni Mack marked it ready for review 07/25/25, 09:12

  12. core-ci voted on patch set 3 V +1 07/25/25, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/82314

  13. Benni Mack commented on patch set 3 07/25/25, 09:38

    Reply

    Done
  14. Georg Ringer uploaded patch set 4 V +1 02/24/26, 12:00

  15. Georg Ringer commented on patch set 4 CR +1 V +1 02/24/26, 12:02

    TcaSlug.php:59 Reply

    I have thought about that as well but I am against it. It is about an additional configuration and not about TCA configuration. If latter could be needed, you can either pass stuff additionally or use the TCA schema API and fetch it
  16. core-ci voted on patch set 4 V +1 02/24/26, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96722

  17. Simon Schaufelberger voted on patch set 4 CR +1 V +1 02/26/26, 00:04

  18. Garvin Hicking commented on patch set 4 02/26/26, 06:31

    Couldn't we pass the whole TCA areay for the column to the userfunc instead, theen anyone could use arbitrary data?
  19. Georg Ringer uploaded patch set 5 CR +1 V +1 02/26/26, 19:33

  20. core-ci voted on patch set 5 V +1 02/26/26, 20:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96936

  21. Georg Ringer updated the commit message in patch set 6 V +1 02/26/26, 20:23

  22. core-ci voted on patch set 6 V +1 02/26/26, 20:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96938

  23. Garvin Hicking commented on patch set 6 CR +1 V +1 02/26/26, 21:06

    Reply

    Thx!
  24. Georg Ringer voted on patch set 6 CR +2 V +2 02/27/26, 08:54

  25. Georg Ringer merged patch set 7 02/27/26, 08:54