Review main Merged

88835[TASK] Extract DateTime to-database transformation from DataHandler

Benjamin Franzke CR +2 V +2 Normal +66 −45 updated 04/07/25, 13:54

Commit message

Add QueryHelper::transformDateTimeToDatabaseValue for later use in
extbase persistence layer.

Also make use of DateTimeFactory for UTC timestamp conversion
to localtime \DateTimeImmutable objects.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2127

Show 12 earlier messages
  1. Benjamin Franzke uploaded patch set 1 03/29/25, 16:38

  2. core-ci voted on patch set 1 V +1 03/29/25, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76643

  1. Benjamin Franzke updated the commit message in patch set 2 V +1 03/31/25, 08:43

  2. core-ci voted on patch set 2 V +1 03/31/25, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76715

  3. Benjamin Franzke rebased onto patch set 3 V +1 04/03/25, 19:21

  4. core-ci voted on patch set 3 V +1 04/03/25, 19:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76966

  5. Stefan Bürk voted on patch set 3 CR +1 V +1 04/04/25, 07:47

  6. Georg Ringer voted on patch set 3 CR +1 V +1 04/04/25, 07:53

  7. Benjamin Franzke voted on patch set 3 CR +2 V +2 04/04/25, 08:16

  8. Andreas Kienast commented on patch set 3 04/04/25, 08:37

    QueryHelper.php:237

    Nitpick: Expected parameter of type '\DateTime', '\DateTimeInterface' provided
  9. Benjamin Franzke voted on patch set 3 CR -1 04/04/25, 08:37

  10. Benjamin Franzke uploaded patch set 4 CR +1 V +1 04/04/25, 09:42

  11. Benjamin Franzke commented on patch set 4 04/04/25, 09:42

    QueryHelper.php:237 Reply

    Thanks! Changed to `createFromInterface`.
  12. core-ci voted on patch set 4 V +1 04/04/25, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76994

  13. Benni Mack commented on patch set 4 04/04/25, 09:53

    DataHandler.php:2045

    I know this is copy/paste. But using '@' ... will bring us to the same situation as we had 2 weeks ago. Let's use the DateTimeFactory here as well. WDYT?
  14. Benjamin Franzke commented on patch set 4 04/04/25, 09:53

    Note: I've decided to keep the logic in v13 backport within DataHandler: > 88943: [TASK] Extract DateTime to-database transformation logic from DataHandler | https://review.typo3.org/c/Packages/TYPO3.CMS/+/88943 Reason: v13 DataHandler code is still muddled with fake utc-0 handling and I don't want to touch that again (too risky), but I'll still backport the QueryHelper method for use in the Extbase consolidation: > 88836: [BUGFIX] Align Extbase DateTime handling to FormEngine and DataHandler | https://review.typo3.org/c/Packages/TYPO3.CMS/+/88836
  15. Benjamin Franzke voted on patch set 4 CR -1 04/04/25, 09:54

  16. Benjamin Franzke uploaded patch set 5 CR -1 V +1 04/04/25, 10:21

  17. Benjamin Franzke commented on patch set 5 04/04/25, 10:21

    DataHandler.php:2045 Reply

    Yea, I can do that. I didn't wanted do do this, since the comparison is not affected by the timezone in use (is still points to the same point in time) and I wanted to keep the change for v13 minimal, but as I figured I shouldn't touch DataHandler v13 in the backport at all, this is fine to be done for main 👍 Done, thanks!
  18. Benjamin Franzke uploaded patch set 6 04/04/25, 10:24

  19. core-ci voted on patch set 5 V +1 04/04/25, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76996

  20. core-ci voted on patch set 6 V +1 04/04/25, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76997

  21. Stefan Bürk voted on patch set 6 CR +1 04/04/25, 21:01

  22. Stefan Bürk voted on patch set 6 V +1 04/05/25, 12:57

  23. Benni Mack voted on patch set 6 CR +1 V +1 04/07/25, 12:56

  24. Benjamin Franzke voted on patch set 6 CR +2 V +2 04/07/25, 13:54

  25. Benjamin Franzke merged patch set 7 04/07/25, 13:54