88835[TASK] Extract DateTime to-database transformation from DataHandler
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2127
Show 12 earlier messages
-
Benjamin Franzke uploaded patch set 1 03/29/25, 16:38
-
core-ci voted on patch set 1 V +1 03/29/25, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76643
-
Benjamin Franzke updated the commit message in patch set 2
V +103/31/25, 08:43 -
core-ci voted on patch set 2 V +1 03/31/25, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76715
-
Benjamin Franzke rebased onto patch set 3
V +104/03/25, 19:21 -
core-ci voted on patch set 3 V +1 04/03/25, 19:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76966
-
Stefan Bürk voted on patch set 3 CR +1 V +1 04/04/25, 07:47
-
Georg Ringer voted on patch set 3 CR +1 V +1 04/04/25, 07:53
-
Benjamin Franzke voted on patch set 3 CR +2 V +2 04/04/25, 08:16
-
Andreas Kienast commented on patch set 3 04/04/25, 08:37
-
Benjamin Franzke voted on patch set 3 CR -1 04/04/25, 08:37
-
Benjamin Franzke uploaded patch set 4
CR +1V +104/04/25, 09:42 -
Benjamin Franzke commented on patch set 4 04/04/25, 09:42
QueryHelper.php:237ReplyThanks! Changed to `createFromInterface`. -
core-ci voted on patch set 4 V +1 04/04/25, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76994
-
Benni Mack commented on patch set 4 04/04/25, 09:53
DataHandler.php:2045I know this is copy/paste. But using '@' ... will bring us to the same situation as we had 2 weeks ago. Let's use the DateTimeFactory here as well. WDYT? -
Benjamin Franzke commented on patch set 4 04/04/25, 09:53
Note: I've decided to keep the logic in v13 backport within DataHandler: > 88943: [TASK] Extract DateTime to-database transformation logic from DataHandler | https://review.typo3.org/c/Packages/TYPO3.CMS/+/88943 Reason: v13 DataHandler code is still muddled with fake utc-0 handling and I don't want to touch that again (too risky), but I'll still backport the QueryHelper method for use in the Extbase consolidation: > 88836: [BUGFIX] Align Extbase DateTime handling to FormEngine and DataHandler | https://review.typo3.org/c/Packages/TYPO3.CMS/+/88836 -
Benjamin Franzke voted on patch set 4 CR -1 04/04/25, 09:54
-
Benjamin Franzke uploaded patch set 5
CR -1V +104/04/25, 10:21 -
Benjamin Franzke commented on patch set 5 04/04/25, 10:21
DataHandler.php:2045ReplyYea, I can do that. I didn't wanted do do this, since the comparison is not affected by the timezone in use (is still points to the same point in time) and I wanted to keep the change for v13 minimal, but as I figured I shouldn't touch DataHandler v13 in the backport at all, this is fine to be done for main 👍 Done, thanks! -
Benjamin Franzke uploaded patch set 6 04/04/25, 10:24
-
core-ci voted on patch set 5 V +1 04/04/25, 10:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76996
-
core-ci voted on patch set 6 V +1 04/04/25, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76997
-
Stefan Bürk voted on patch set 6 CR +1 04/04/25, 21:01
-
Stefan Bürk voted on patch set 6 V +1 04/05/25, 12:57
-
Benni Mack voted on patch set 6 CR +1 V +1 04/07/25, 12:56
-
Benjamin Franzke voted on patch set 6 CR +2 V +2 04/07/25, 13:54
-
Benjamin Franzke merged patch set 7 04/07/25, 13:54
QueryHelper.php:237