88836[BUGFIX] Align Extbase DateTime handling to FormEngine and DataHandler
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Markus Klein +1
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 5
- Bug #68651Datetime() properties have wrong timezone
- Bug #80349Extbase mapping of \DateTime for integer values does not set timezone with region string but only offset
- Bug #100649Extbase DataMapper doesn't respect datetime when 0 or 0000-00-00 or 0000-00-00 00:00:00 or 00:00:00
- Bug #106364DatetimeElement stores format=time in seconds, while extbase interprets it as timezone-offset-mapped UTC timestamp, when php timezone is not UTC
- Bug #105666Nullable native time fields store "00:00:00" instead of null if value is unset
Files 15
- Build/phpstan/phpstan-baseline.neon+0 −6
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −0
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml3+11 −0
- typo3/sysext/core/Documentation/Changelog/13.4.x/Important-106467-AlignExtbaseDateTimeHandlingToFormEngineAndDataHandler.rst8new+215 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/ColumnMap.php+8 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/ColumnMapFactory.php+1 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php+51 −6
- typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php+16 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/DateExample.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Fixtures/BackendTest/getPlainValueMapsDateTimeImport.csvrenamed+0 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Fixtures/BackendTest/getPlainValueReturnsNullForNullableDateTimePropertyAssertion.csvdeleted+0 −3
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/Mapper/DataMapperTest.php+61 −13
- typo3/sysext/extbase/Tests/Functional/Persistence/Generic/BackendTest.php+114 −7
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php+2 −0
- typo3/sysext/install/Resources/Private/Templates/Settings/FeaturesGetContent.html+1 −1
Review log 3043
Show 1118 earlier messages
-
Benjamin Franzke uploaded patch set 1 03/29/25, 16:47
-
Benjamin Franzke marked it work in progress 03/29/25, 16:47
-
core-ci voted on patch set 1 V +1 03/29/25, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76644
-
Benjamin Franzke uploaded patch set 2
V +103/30/25, 05:13 -
core-ci voted on patch set 2 V +1 03/30/25, 05:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76660
-
Benjamin Franzke uploaded patch set 3
V +103/30/25, 18:53 -
core-ci voted on patch set 3 V +1 03/30/25, 19:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76679
-
Benjamin Franzke uploaded patch set 4
V +103/31/25, 21:02 -
core-ci voted on patch set 4 V +1 03/31/25, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76736
-
Benjamin Franzke uploaded patch set 5
V +104/03/25, 19:21 -
core-ci voted on patch set 5 V +1 04/03/25, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76967
-
Benjamin Franzke rebased onto patch set 6
V +104/04/25, 12:19 -
core-ci voted on patch set 6 V +1 04/04/25, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77002
-
Benjamin Franzke rebased onto patch set 7
V +104/07/25, 13:57 -
core-ci voted on patch set 7 V +1 04/07/25, 14:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77141
-
Benjamin Franzke wrote 04/07/25, 14:34
Topic set to extbase -
Benni Mack commented on patch set 7 04/07/25, 17:13
Important-106467-AlignExtbaseDateTimeHandlingToFormEngineAndDataHandler.rst:54should we explain the difference of that change based on CEST / CET?Important-106467-AlignExtbaseDateTimeHandlingToFormEngineAndDataHandler.rst:60"Nullable" ?Important-106467-AlignExtbaseDateTimeHandlingToFormEngineAndDataHandler.rst:84"Not that" = "Note that"? -
Benjamin Franzke uploaded patch set 8
V +104/07/25, 17:31
-
Benjamin Franzke commented on patch set 8 04/07/25, 17:31
Important-106467-AlignExtbaseDateTimeHandlingToFormEngineAndDataHandler.rst:54ReplyAck, added an example as explanation.Important-106467-AlignExtbaseDateTimeHandlingToFormEngineAndDataHandler.rst:60ReplyDoneImportant-106467-AlignExtbaseDateTimeHandlingToFormEngineAndDataHandler.rst:84ReplyDone -
core-ci voted on patch set 8 V +1 04/07/25, 17:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77156
-
Benjamin Franzke rebased onto patch set 9
V +104/11/25, 09:02 -
core-ci voted on patch set 9 V +1 04/11/25, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77508
-
Benni Mack commented on patch set 9 04/11/25, 12:04
Thanks for the patch. Apart from the minor textual changes, this is really cool! two things: 1. Why not enforce this option in v14 already? 2. Can / should we elaborate in the RST what the extension authors should have a look at and might need adaptions? I mean, if I read through the RST, I'd like to know if I'm affected if I have an Extbase extension with non-native datetime, and no timesec etc. I'm OK... you know? And: I most likely have some quirks in my models to overcome this problem, so this should also be mentioned that in v14 people should remove their timezone calculation magic.DefaultConfigurationDescription.yaml:197should we close the </li>s?Important-106467-AlignExtbaseDateTimeHandlingToFormEngineAndDataHandler.rst:30consistent -
Benjamin Franzke commented on patch set 9 04/11/25, 13:25
Reply
> Why not enforce this option in v14 already? You mean not just defaulting to it (also for updated instances), but completely removing the possibility to revert the behavior and effectively remove the old code directly? Two (and a half) reasons: 1. It's very old extbase behavior 2. We had no deprecation 2a could be a separate change > I mean, if I read through the RST, I'd like to know if I'm affected if I have an Extbase extension with non-native datetime, and no timesec etc. I'm OK... you know? I know what you mean, and actually tried to accomplish that with the RST, but obviously failed. It's a) not that simple and b) a guessing game… Will try to iterate on that.DefaultConfigurationDescription.yaml:197ReplyI let them open on purpose: https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/li#:~:text=The%20end%20tag%20can%20be%20omitted%20if%20the%20list%20item%20is%20immediately%20followed%20by%20another%20%3Cli%3E%20element%2C%20or%20if%20there%20is%20no%20more%20content%20in%20its%20parent%20element. (Will switch this to markdown once we have setting api anyway) -
Benjamin Franzke uploaded patch set 10
V +104/11/25, 13:29 -
Benjamin Franzke commented on patch set 10 04/11/25, 13:29
Important-106467-AlignExtbaseDateTimeHandlingToFormEngineAndDataHandler.rst:30ReplyDone -
core-ci voted on patch set 10 V +1 04/11/25, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77540
-
Georg Ringer voted on patch set 10 CR +2 05/09/25, 07:11
-
Georg Ringer voted on patch set 10 CR 0 05/09/25, 07:11
-
Benjamin Franzke uploaded patch set 11
V +105/11/25, 11:20 -
Benjamin Franzke commented on patch set 11 05/11/25, 11:20
Reply
DoneDefaultConfigurationDescription.yaml:197ReplyDone -
core-ci voted on patch set 11 V -1 05/11/25, 11:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78774
-
Benjamin Franzke uploaded patch set 12
V -105/11/25, 14:33 -
core-ci voted on patch set 12 V +1 05/11/25, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78778
-
Benjamin Franzke rebased onto patch set 13
V +105/20/25, 12:19Rebase -
core-ci voted on patch set 13 V +1 05/20/25, 12:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79239
-
Benni Mack voted on patch set 13 CR +1 V +1 05/21/25, 14:33
-
Markus Klein voted on patch set 13 CR +1 05/22/25, 17:53
-
Andreas Kienast voted on patch set 13 CR +1 V +1 05/23/25, 10:05
-
Benjamin Franzke voted on patch set 13 CR +2 V +2 05/23/25, 10:31
-
Benjamin Franzke merged patch set 14 05/23/25, 10:41
-
Mathias Brodala commented on patch set 14 05/23/25, 10:46
Hm, but this is what happens due to being set in DefaultConfiguration instead of FactoryConfiguration or do I miss something? -
Benjamin Franzke commented on patch set 14 05/23/25, 14:22
Reply
yes in main for v14, but the v13 backport sets the value to false by default: https://review.typo3.org/c/Packages/TYPO3.CMS/+/88945/6/typo3/sysext/core/Configuration/DefaultConfiguration.php#86 …and sets true in https://review.typo3.org/c/Packages/TYPO3.CMS/+/88945/6/typo3/sysext/core/Configuration/FactoryConfiguration.php#29