Review main Merged

88838[TASK] Mitigate invalid `GeneralUtility::$indpEnvCache` state

Stefan Bürk CR +2 V +2 Easy +2 −0 updated 03/31/25, 05:59

Commit message

`typo3/testing-framework` resets the `GeneralUtility::$indpEnvCache`
during the test tear-done phase, but some tests needs to ensure clean
state during the setUp phase after manipulating php super globals, for
example `$_SERVER['HOST']`. After changing these super-globals, the
cache needs to be cleared to ensure that a test expection can match
and does not operate on a stalled state.

Reveleaded by a nightly random unit tests, this change adds cache
clear method call after changing the super global to the test and
ensures that the expectation can be met.

Can be (currently) verified using following command(s):

```
Build/Scripts/runTests.sh -s composerInstallMin -p 8.3 \
&& Build/Scripts/runTests.sh -s unitRandom -p 8.3 -- \
  --stop-on-error --stop-on-failure --random-order-seed 1743211040
```

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Stefan Bürk uploaded patch set 1 03/30/25, 13:48

  2. core-ci voted on patch set 1 V +1 03/30/25, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76667

  3. Georg Ringer voted on patch set 1 CR +1 V +1 03/30/25, 18:17

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 03/30/25, 21:01

  5. Georg Ringer voted on patch set 1 CR +2 V +2 03/31/25, 05:59

  6. Georg Ringer merged patch set 2 03/31/25, 05:59