88840[BUGFIX] Fix native datetime transformation in Extbase query constraints
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 6
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php+3 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php7+28 −17
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Repository/DateExampleRepository.phpnew+27 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Repository/DateTimeImmutableExampleRepository.phpnew+27 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/QueryParserTestImport.csv+6 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/QueryParserTest.php2+91 −0
Review log 2027
Show 12 earlier messages
-
Benjamin Franzke uploaded patch set 1 03/30/25, 16:53
-
core-ci voted on patch set 1 V -1 03/30/25, 17:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76675
-
Benjamin Franzke uploaded patch set 2
V -103/30/25, 17:08 -
Benjamin Franzke uploaded patch set 3 03/30/25, 17:11
-
core-ci voted on patch set 2 V -1 03/30/25, 17:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76676
-
core-ci voted on patch set 3 V +1 03/30/25, 17:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76677
-
Benjamin Franzke commented on patch set 3 03/30/25, 17:20
QueryParserTest.php:185This case was broken and has now been fixed, see failure in CI run from patchset 2 (which contained tests only, without fix applied): https://git.typo3.org/typo3/CI/cms/-/jobs/4334793 -
Benjamin Franzke uploaded patch set 4
V +103/30/25, 20:39 -
core-ci voted on patch set 4 V +1 03/30/25, 20:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76692
-
Benjamin Franzke wrote 04/07/25, 14:34
Topic set to extbase -
Benjamin Franzke updated the commit message in patch set 5
V +104/07/25, 17:37 -
core-ci voted on patch set 5 V +1 04/07/25, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77159
-
Benjamin Franzke commented on patch set 5 CR -1 04/10/25, 08:03
Typo3DbQueryParser.php:508Typo, needs to be columnMapOut -
Benjamin Franzke uploaded patch set 6
CR -1V +104/10/25, 08:09 -
Benjamin Franzke commented on patch set 6 04/10/25, 08:09
Typo3DbQueryParser.php:508ReplyDone -
core-ci voted on patch set 6 V +1 04/10/25, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77400
-
Andreas Kienast commented on patch set 6 04/10/25, 08:22
Typo3DbQueryParser.php:380Left-over or will this be used? -
Benjamin Franzke commented on patch set 6 04/10/25, 08:28
Typo3DbQueryParser.php:380Replyhelpful for non-ide users to see that the variable is passed by reference ;) yea yea, I know, I should remove that, we do not do that in other places as well. 😂 -
Benjamin Franzke uploaded patch set 7
V +104/10/25, 08:33 -
Benjamin Franzke commented on patch set 7 04/10/25, 08:33
Typo3DbQueryParser.php:380ReplyDone -
core-ci voted on patch set 7 V +1 04/10/25, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77407
-
Andreas Kienast commented on patch set 7 CR +1 04/10/25, 09:21
Typo3DbQueryParser.php:388Note for a later point: `$plainValue` is never null here. -
Benni Mack commented on patch set 7 CR +1 04/10/25, 15:33
Typo3DbQueryParser.php:504we should resolve this at a later point again -
Benni Mack commented on patch set 7 V +1 04/10/25, 15:34
great stuff! thank you! -
Stefan Bürk voted on patch set 7 CR +1 V +1 04/10/25, 20:31
-
Benjamin Franzke voted on patch set 7 CR +2 V +2 04/11/25, 08:10
-
Benjamin Franzke merged patch set 8 04/11/25, 08:11
QueryParserTest.php:175