Review main Merged

88840[BUGFIX] Fix native datetime transformation in Extbase query constraints

Benjamin Franzke CR +2 V +2 Normal +182 −19 updated 04/11/25, 08:11

Commit message

Convert DateTime objects to string representation instead of an integer
timestamp for native datetime fields.
Resolve and pass the `ColumnMap` information for any invocation of
`DataMapper->getPlainValue` in order to apply the detection for the
underlying database implementation based on TCA definition of
the respective database field of extbase datetime properties.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 2027

Show 12 earlier messages
  1. Benjamin Franzke uploaded patch set 1 03/30/25, 16:53

  2. core-ci voted on patch set 1 V -1 03/30/25, 17:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76675

  1. Benjamin Franzke uploaded patch set 2 V -1 03/30/25, 17:08

  2. Benjamin Franzke uploaded patch set 3 03/30/25, 17:11

  3. core-ci voted on patch set 2 V -1 03/30/25, 17:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76676

  4. core-ci voted on patch set 3 V +1 03/30/25, 17:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76677

  5. Benjamin Franzke commented on patch set 3 03/30/25, 17:20

    QueryParserTest.php:175

    This case was broken and has now been fixed, see failure in CI run from patchset 2 (which contained tests only, without fix applied): https://git.typo3.org/typo3/CI/cms/-/jobs/4334793

    QueryParserTest.php:185

    This case was broken and has now been fixed, see failure in CI run from patchset 2 (which contained tests only, without fix applied): https://git.typo3.org/typo3/CI/cms/-/jobs/4334793
  6. Benjamin Franzke uploaded patch set 4 V +1 03/30/25, 20:39

  7. core-ci voted on patch set 4 V +1 03/30/25, 20:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76692

  8. Benjamin Franzke wrote 04/07/25, 14:34

    Topic set to extbase
  9. Benjamin Franzke updated the commit message in patch set 5 V +1 04/07/25, 17:37

  10. core-ci voted on patch set 5 V +1 04/07/25, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77159

  11. Benjamin Franzke commented on patch set 5 CR -1 04/10/25, 08:03

    Typo3DbQueryParser.php:508

    Typo, needs to be columnMapOut
  12. Benjamin Franzke uploaded patch set 6 CR -1 V +1 04/10/25, 08:09

  13. Benjamin Franzke commented on patch set 6 04/10/25, 08:09

    Typo3DbQueryParser.php:508 Reply

    Done
  14. core-ci voted on patch set 6 V +1 04/10/25, 08:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77400

  15. Andreas Kienast commented on patch set 6 04/10/25, 08:22

    Typo3DbQueryParser.php:380

    Left-over or will this be used?
  16. Benjamin Franzke commented on patch set 6 04/10/25, 08:28

    Typo3DbQueryParser.php:380 Reply

    helpful for non-ide users to see that the variable is passed by reference ;) yea yea, I know, I should remove that, we do not do that in other places as well. 😂
  17. Benjamin Franzke uploaded patch set 7 V +1 04/10/25, 08:33

  18. Benjamin Franzke commented on patch set 7 04/10/25, 08:33

    Typo3DbQueryParser.php:380 Reply

    Done
  19. core-ci voted on patch set 7 V +1 04/10/25, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77407

  20. Andreas Kienast commented on patch set 7 CR +1 04/10/25, 09:21

    Typo3DbQueryParser.php:388

    Note for a later point: `$plainValue` is never null here.
  21. Benni Mack commented on patch set 7 CR +1 04/10/25, 15:33

    Typo3DbQueryParser.php:504

    we should resolve this at a later point again
  22. Benni Mack commented on patch set 7 V +1 04/10/25, 15:34

    great stuff! thank you!
  23. Stefan Bürk voted on patch set 7 CR +1 V +1 04/10/25, 20:31

  24. Benjamin Franzke voted on patch set 7 CR +2 V +2 04/11/25, 08:10

  25. Benjamin Franzke merged patch set 8 04/11/25, 08:11