Review 13.4 Merged

88843[TASK] Update `phpstan/phpstan` and mitigate reportings

Stefan Bürk CR +2 V +2 Easy +24 −25 updated 03/31/25, 05:46

Commit message

This change updates phpstan to a newer version and
includes minor adoption to mitigate new findings.

Note that this has not been detected recently with
the nightlies due to an issue with packagist data
retrieval having this change as preparation to fix
it with a dedicated change.

Adoptions before generateing baseline are adjusted
for backports.

Used command(s):

```
Build/Scripts/runTests.sh -s composer -- require --dev \
  'phpstan/phpstan':'^2.1.11' \
  'phpstan/phpstan-phpunit':'^2.0.6' \
&& Build/Scripts/runTests.sh -s phpstanGenerateBaseline
```

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 57

  1. Stefan Bürk uploaded patch set 1 03/30/25, 19:40

  2. Stefan Bürk uploaded patch set 2 03/30/25, 19:50

  3. core-ci voted on patch set 1 V -1 03/30/25, 19:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76685

  4. core-ci voted on patch set 2 V +1 03/30/25, 20:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76688

  5. Garvin Hicking voted on patch set 2 CR +1 V +1 03/30/25, 20:19

  6. Georg Ringer voted on patch set 2 CR +2 V +2 03/31/25, 05:46

  7. Georg Ringer merged patch set 3 03/31/25, 05:46