88847[BUGFIX] Allow to use FileReferences in 'Enlarge on click'
Commit message
Review
-
Code review CR -1
- Benni Mack -1
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 1
Review log 67
-
Garvin Hicking uploaded patch set 1 03/31/25, 12:16
-
Garvin Hicking commented on patch set 1 03/31/25, 12:17
(Copied patch suggestion from Sascha, thanks! I have not yet fully verified this, but it looks logical to me) -
core-ci voted on patch set 1 V +1 03/31/25, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76720
-
Benni Mack commented on patch set 1 CR -1 03/31/25, 12:57
ContentObjectRenderer.php:1017this is most likely wrong... I think we need 'file:' . $url->getUid() . and for file references, we need somethign that respects the crop variants? -
Garvin Hicking commented on patch set 1 03/31/25, 13:32
ContentObjectRenderer.php:1017Reply UnresolvedIMO viewing the "zoomed" version of a file reference should yield the full image and not a cropped variant? i believe the js popup also does not apply crop. (i have not tested this myself yet, I wanted to get it into the system for testing. marking as wip for now) -
Garvin Hicking marked it work in progress 03/31/25, 13:32
-
Benni Mack abandoned the change 11/10/26, 10:54
cannot reproduce according to issue - issue is closed. abandoning