Review main Merged Breaking

88852[!!!][TASK] Remove year from eval

Georg Ringer CR +2 V +2 Hard +176 −122 updated 06/11/25, 11:31

Commit message

The eval="year" implementation has always been incomplete and also
doesn't make any sense. Therefore it can be dropped.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 2637

Show 912 earlier messages
  1. Georg Ringer uploaded patch set 1 03/31/25, 20:28

  2. core-ci voted on patch set 1 V -1 03/31/25, 20:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76731

  3. Georg Ringer uploaded patch set 2 V -1 03/31/25, 20:48

  4. core-ci voted on patch set 2 V -1 03/31/25, 21:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76735

  5. Georg Ringer uploaded patch set 3 V -1 03/31/25, 21:11

  6. core-ci voted on patch set 3 V +1 03/31/25, 21:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76737

  7. Georg Ringer commented on patch set 3 04/01/25, 05:53

    This change is ready for review.
  8. Garvin Hicking commented on patch set 3 04/01/25, 06:11

    I think we should do a tca migration to ensure number format, so that these fields dont suddenly fall back to text evaluation?
  9. Georg Ringer commented on patch set 3 04/01/25, 06:52

    Reply

    I thought about that as well but input_24 is a varchar field, I'm not sure if we should overrule that but we should state that in the rst for sure! wanna give it a shot?
  10. Garvin Hicking commented on patch set 3 CR -1 04/01/25, 09:37

    Reply

    I would prefer to make 'eval=year' be TCA migrated to 'eval=num' instead, raise a deprecation and only finally remove it in v15? I do think this might have been used in existing projects, and by just accepting strings instead of numbers suddenly, this will create functional trouble. We shouldn't cause unnecessary pain here. Actually... how about keeping 'year' as an alias for 'num' around, and just change documentation? First variant picking up on this: https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-TCA/pull/1246
  11. Benni Mack commented on patch set 3 04/01/25, 19:01

    Reply

    well, I think we don't need duplicate stuff... people should migrate to something useful, and we need to tell them. So: let's keep it and deprecate so people can migrate to either eval=num or type=number.
  12. Stefan Froemken commented on patch set 4 CR -1 V +1 04/07/25, 20:26

    Published edit on patch set 3.
  1. Stefan Froemken commented on patch set 4 CR -1 04/07/25, 20:29

    AbstractFormElement.php:272

    remove

    Breaking-98070-RemoveEvalMethodYear.rst:40

    This example does not what you are describing above
  2. core-ci voted on patch set 4 V +1 04/07/25, 20:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77165

  3. Georg Ringer uploaded patch set 5 CR -1 V +1 04/08/25, 19:55

  4. core-ci voted on patch set 5 V -1 04/08/25, 20:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77234

  5. Georg Ringer uploaded patch set 6 V -1 04/08/25, 20:05

  6. core-ci voted on patch set 6 V +1 04/08/25, 20:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77239

  7. Stefan Froemken commented on patch set 7 V +1 04/10/25, 13:01

    Published edit on patch set 6.
  8. Stefan Froemken commented on patch set 7 CR +1 04/10/25, 13:03

    Breaking-98070-RemoveEvalMethodYear.rst:40 Reply

    Done

    Breaking-98070-RemoveEvalMethodYear.rst:59

    I have changed the example to the same approach we done in TYPO3 docs
  9. Stefan Froemken commented on patch set 7 04/10/25, 13:03

    AbstractFormElement.php:272 Reply

    Done
  10. core-ci voted on patch set 7 V +1 04/10/25, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77436

  11. Georg Ringer uploaded patch set 8 CR +1 V +1 04/10/25, 18:36

  12. core-ci voted on patch set 8 V +1 04/10/25, 18:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77459

  13. Garvin Hicking commented on patch set 8 04/10/25, 18:49

    Reply

    I re-read that a few times but I'm not sure what to do: A: Do it like current patch. directly break and log a notice. B: Rework the patch, keep functionality, deprecate it properly, remove it in v15 only

    Breaking-98070-RemoveEvalMethodYear.rst:24

    This may be nitpicking but I gotta: With the current approach, this isn't really a deprecation message, it's a "breaking change/obsoletion log message.". Deprecation would mean that the current code will break in the future, not "right now". Let's rephrase this to something like "will report a TCA migration notice of the breaking change" if this patch carries?
  14. Benni Mack uploaded patch set 9 V +1 06/10/25, 19:03

  15. core-ci voted on patch set 9 V +1 06/10/25, 19:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80155

  16. Oli Bartsch uploaded patch set 10 V +1 06/11/25, 08:33

  17. Oli Bartsch commented on patch set 10 CR +1 V +1 06/11/25, 08:35

    Reply

    Let's get this in with option A now.

    Breaking-98070-RemoveEvalMethodYear.rst:24 Reply

    It's a message added to the deprecation log. We always documented it this way. So I think this is fine. Breaking in the sense of the functionality does no longer exist but the report is a deprecation log entry.
  18. core-ci voted on patch set 10 V -1 06/11/25, 08:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80181

  19. Oli Bartsch uploaded patch set 11 CR +1 V +1 06/11/25, 09:03

  20. core-ci voted on patch set 11 V +1 06/11/25, 09:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/80183

  21. Oli Bartsch voted on patch set 11 CR +1 V +1 06/11/25, 09:12

  22. Benni Mack commented on patch set 11 CR +1 V +1 06/11/25, 10:42

    @garvin@hick.ing you're OK like this? I think that's a good approach.
  23. Garvin Hicking commented on patch set 11 CR +1 06/11/25, 11:26

    Reply

    Yes I'm okay with it, intent is now explicitly stated. I can't personally judge the full impact of this right now (e.g. what this does to migrated fields that contain a timestamp and how people could format the timestamp back again to a datetime field or so), but these are edge cases. If you feel good with this, no objections to merge.
  24. Benni Mack voted on patch set 11 CR +2 V +2 06/11/25, 11:31

  25. Benni Mack merged patch set 12 06/11/25, 11:31