Review 13.4 Merged

88873[TASK] Make container hosts IPv4 addresses manageable with GitLab

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 04/01/25, 12:16

Commit message

This change replace hardcoded hosts ipv4 override in
`Build/Scripts/runTests.sh` with a variable to allow
managing it as GitLab variable in the repository for
test execution.

Upgrading runner to podman 5 is planned and hopefully
makes this workaround obsolete, but having it in place
for quicker adjustment does not hurt as intermediate
solution.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 35

  1. Stefan Bürk commented on patch set 1 04/01/25, 08:39

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 04/01/25, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76762

  3. core-ci commented on patch set 1 04/01/25, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76763

  4. Stefan Bürk voted on patch set 1 CR +2 V +2 04/01/25, 12:16

  5. Stefan Bürk merged patch set 2 04/01/25, 12:16