88882[TASK] Pass FormEngine instance into Validation
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Georg Ringer +1
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Andreas Kienast +2
- Georg Ringer +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/backend/tests/form-engine-validation-test.ts+0 −2
- Build/Sources/TypeScript/backend/form-engine-validation.ts+19 −18
- Build/Sources/TypeScript/backend/form-engine.ts+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-validation.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine.js+1 −1
Review log 1418
-
Andreas Kienast uploaded patch set 1 04/01/25, 13:40
-
core-ci voted on patch set 1 V -1 04/01/25, 13:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76793
-
Andreas Kienast uploaded patch set 2
V -104/01/25, 13:51 -
core-ci voted on patch set 2 V +1 04/01/25, 13:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76796
-
Georg Ringer voted on patch set 2 CR +1 V +1 04/01/25, 14:46
-
Stefan Bürk voted on patch set 2 CR +1 04/02/25, 16:07
-
Stefan Bürk voted on patch set 2 V +1 04/02/25, 16:13
-
Stefan Bürk commented on patch set 2 04/02/25, 16:27
Should we backport his change to 13.4 ? Not sure about the planned "refactorings" and if they should be also backported do lower eventually bugfix backports barriers. The JS world is here little bit out of my range to make a risk assesment here. Just wanted to question it. -
Andreas Kienast updated the commit message in patch set 3
CR +1V +104/03/25, 09:47 -
Andreas Kienast commented on patch set 3 04/03/25, 09:47
Reply
Done -
core-ci voted on patch set 3 V +1 04/03/25, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76932
-
Andreas Kienast uploaded patch set 4
V +104/07/25, 14:40 -
core-ci voted on patch set 4 V +1 04/07/25, 14:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77149
-
Stefan Bürk voted on patch set 4 CR +1 V +1 04/07/25, 23:00
-
Georg Ringer voted on patch set 4 CR +1 V +1 04/08/25, 07:30
-
Christian Kuhn voted on patch set 4 CR +1 04/08/25, 09:22
-
Andreas Kienast voted on patch set 4 CR +2 V +2 04/08/25, 09:35
-
Andreas Kienast merged patch set 5 04/08/25, 10:11