Review main Merged

88885[BUGFIX] Set the SYS_LASTCHANGED using PageContentFetchingProcessor

Georg Ringer CR +2 V +2 Easy +17 −5 updated 04/07/25, 12:51

Commit message

If content is rendered using the new way using cObj PAGEVIEW with the
data-processor `page-content`, the timestamp must be also updated.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1114

  1. Georg Ringer uploaded patch set 1 04/01/25, 17:04

  2. Georg Ringer commented on patch set 1 04/01/25, 17:04

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 04/01/25, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76806

  4. Benni Mack uploaded patch set 2 V +1 04/02/25, 14:47

  5. core-ci voted on patch set 2 V +1 04/02/25, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76899

  6. Georg Ringer commented on patch set 2 04/02/25, 15:36

    ContentObjectRenderer.php:1038

    Guess wei should rename the variable now, tstamp does not fit anymore
  7. Benni Mack commented on patch set 3 V +1 04/03/25, 06:17

    Published edit on patch set 2.
  8. Benni Mack commented on patch set 3 CR +1 04/03/25, 06:17

    ContentObjectRenderer.php:1038 Reply

    Done
  9. core-ci voted on patch set 3 V +1 04/03/25, 06:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76923

  10. Garvin Hicking commented on patch set 3 CR +1 04/03/25, 06:48

    lgtm, how could I quickly/easily verify this?
  11. Georg Ringer commented on patch set 3 CR +1 V +1 04/03/25, 06:50

    Reply

    1. take a look at the sitemap.xml > modified date 2. modify content of a page, + render it in frontend 3. reload sitemap => date must be changed
  12. Christian Kuhn voted on patch set 3 CR +1 V +1 04/07/25, 10:46

  13. Benni Mack voted on patch set 3 CR +2 V +2 04/07/25, 12:51

  14. Benni Mack merged patch set 4 04/07/25, 12:51