Review main Merged

88888[TASK] Use NewRecordWizard in FormEditor

Josua Vogel CR +2 V +2 Hard +267 −118 updated 04/15/25, 13:49

Commit message

In the FormEditor, the modals for new form elements
and form steps have been adapted so that the
NewRecordWizard component is reused.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 35

Show 15 more files

Review log 2839

Show 1114 earlier messages
  1. Josua Vogel uploaded patch set 1 04/01/25, 17:52

  2. core-ci voted on patch set 1 V +1 04/01/25, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76811

  3. Georg Ringer commented on patch set 1 04/01/25, 19:37

    can we align the text left?
  4. Benni Mack voted on patch set 1 CR +1 V +1 04/01/25, 19:38

  5. Josua Vogel commented on patch set 1 04/02/25, 06:39

    Reply

    Of course. Also, do you think we shouldn´t center the icons, but align them at the top left?
  6. Benjamin Kott commented on patch set 1 CR -2 04/02/25, 07:21

    we don't want to have button contexts wrapped here, this leads to unforeseeable layout shifts. please consider adding an ellipsis or wrap the whole button to the next line if possible.
  7. Benjamin Kott commented on patch set 1 04/02/25, 07:25

    will remove -2 once adjusted, it´s only to ensure that i review it again
  8. Josua Vogel commented on patch set 1 04/02/25, 08:03

    Reply

    I understand your comment. I don't like ellipsis or wrapping the entire button. Should we perhaps rethink the entire structure of the modal content and visually align it with the new content element modal?
  9. Benjamin Kott commented on patch set 1 04/02/25, 08:13

    Reply

    sounds like a good idea and worth following!
  10. Josua Vogel uploaded patch set 2 CR +1 V +1 04/02/25, 10:01

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  11. core-ci voted on patch set 2 V -1 04/02/25, 10:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76856

  12. Josua Vogel uploaded patch set 3 V -1 04/02/25, 11:47

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  13. core-ci voted on patch set 3 V +1 04/02/25, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76880

  14. Josua Vogel commented on patch set 3 04/02/25, 12:11

    Reply

    I have revised the modal content
  1. Benjamin Kott commented on patch set 3 CR -2 04/03/25, 06:34

    While it's not closer, to the new content element modal, i think we should reuse the typo3-backend-new-record-wizard here in one way or another. It provides the benefit of having navigable categories and the search bar. If we manage to reuse the component, we would also reduce the maintenance needs here as we only need to maintain 1 component while keeping visual integrity and functionality shared across the backend.
  2. Josua Vogel uploaded patch set 4 V +1 04/11/25, 10:28

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  3. core-ci voted on patch set 4 V -1 04/11/25, 10:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77513

  4. Josua Vogel uploaded patch set 5 V -1 04/11/25, 10:44

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  5. core-ci voted on patch set 5 V -1 04/11/25, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77514

  6. Benni Mack wrote 04/11/25, 15:49

    Removed reviewer Benni Mack.
  7. Josua Vogel uploaded patch set 6 V -1 04/13/25, 07:06

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  8. core-ci voted on patch set 6 V +1 04/13/25, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77668

  9. Benjamin Kott uploaded patch set 7 V +1 04/14/25, 07:04

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  10. Benjamin Kott commented on patch set 7 CR -2 04/14/25, 07:06

    Reply

    Done
  11. core-ci voted on patch set 7 V +1 04/14/25, 07:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77686

  12. Benjamin Kott uploaded patch set 8 V +1 04/14/25, 13:56

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  13. Benjamin Kott voted on patch set 8 CR 0 04/14/25, 13:56

  14. core-ci voted on patch set 8 V -1 04/14/25, 14:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77701

  15. Benjamin Kott uploaded patch set 9 V -1 04/15/25, 08:02

  16. core-ci voted on patch set 9 V +1 04/15/25, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77738

  17. Andreas Kienast commented on patch set 9 CR -1 04/15/25, 09:26

    on it
  18. Andreas Kienast uploaded patch set 10 CR -1 V +1 04/15/25, 09:34

  19. Andreas Kienast commented on patch set 10 04/15/25, 09:35

    Reply

    Done
  20. core-ci voted on patch set 10 V +1 04/15/25, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77743

  21. Benjamin Kott uploaded patch set 11 V +1 04/15/25, 12:25

  22. Andreas Kienast voted on patch set 11 CR +1 V +1 04/15/25, 12:29

  23. core-ci voted on patch set 11 V +1 04/15/25, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77755

  24. Benjamin Kott voted on patch set 11 CR +2 V +2 04/15/25, 13:40

  25. Benjamin Kott merged patch set 12 04/15/25, 13:49