88888[TASK] Use NewRecordWizard in FormEditor
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Kott +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 35
- Build/Sources/TypeScript/backend/new-record-wizard.ts+85 −37
- Build/Sources/TypeScript/form/backend/form-editor/modals-component.ts+12 −14
- typo3/sysext/backend/Resources/Public/JavaScript/new-record-wizard.js+1 −1
- typo3/sysext/form/Classes/Controller/FormEditorController.php+16 −11
- typo3/sysext/form/Configuration/Yaml/FormElements/AdvancedPassword.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Checkbox.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/ContentElement.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/CountrySelect.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Date.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/DatePicker.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Email.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Fieldset.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/FileUpload.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/GridRow.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Hidden.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/ImageUpload.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/MultiCheckbox.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/MultiSelect.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Number.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Page.yaml+1 −0
Show 15 more files
- typo3/sysext/form/Configuration/Yaml/FormElements/Password.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/RadioButton.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/SingleSelect.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/StaticText.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/SummaryPage.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Telephone.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Text.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Textarea.yaml+1 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Url.yaml+1 −0
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Modals/InsertElements.html+6 −19
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Modals/InsertPages.html+7 −19
- typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/InlineTemplates.html+1 −1
- typo3/sysext/form/Resources/Private/Language/Database.xlf+89 −0
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/modals-component.js+1 −1
- typo3/sysext/form/Tests/Functional/Controller/FormEditorControllerTest.php+24 −15
Review log 2839
Show 1114 earlier messages
-
Josua Vogel uploaded patch set 1 04/01/25, 17:52
-
core-ci voted on patch set 1 V +1 04/01/25, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76811
-
Georg Ringer commented on patch set 1 04/01/25, 19:37
can we align the text left? -
Benni Mack voted on patch set 1 CR +1 V +1 04/01/25, 19:38
-
Josua Vogel commented on patch set 1 04/02/25, 06:39
Reply
Of course. Also, do you think we shouldn´t center the icons, but align them at the top left? -
Benjamin Kott commented on patch set 1 CR -2 04/02/25, 07:21
we don't want to have button contexts wrapped here, this leads to unforeseeable layout shifts. please consider adding an ellipsis or wrap the whole button to the next line if possible. -
Benjamin Kott commented on patch set 1 04/02/25, 07:25
will remove -2 once adjusted, it´s only to ensure that i review it again -
Josua Vogel commented on patch set 1 04/02/25, 08:03
Reply
I understand your comment. I don't like ellipsis or wrapping the entire button. Should we perhaps rethink the entire structure of the modal content and visually align it with the new content element modal? -
Benjamin Kott commented on patch set 1 04/02/25, 08:13
Reply
sounds like a good idea and worth following! -
Josua Vogel uploaded patch set 2
CR +1V +104/02/25, 10:01Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 2 V -1 04/02/25, 10:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76856
-
Josua Vogel uploaded patch set 3
V -104/02/25, 11:47Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 3 V +1 04/02/25, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76880
-
Josua Vogel commented on patch set 3 04/02/25, 12:11
Reply
I have revised the modal content
-
Benjamin Kott commented on patch set 3 CR -2 04/03/25, 06:34
While it's not closer, to the new content element modal, i think we should reuse the typo3-backend-new-record-wizard here in one way or another. It provides the benefit of having navigable categories and the search bar. If we manage to reuse the component, we would also reduce the maintenance needs here as we only need to maintain 1 component while keeping visual integrity and functionality shared across the backend. -
Josua Vogel uploaded patch set 4
V +104/11/25, 10:28Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 4 V -1 04/11/25, 10:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77513
-
Josua Vogel uploaded patch set 5
V -104/11/25, 10:44Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 5 V -1 04/11/25, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77514
-
Benni Mack wrote 04/11/25, 15:49
Removed reviewer Benni Mack. -
Josua Vogel uploaded patch set 6
V -104/13/25, 07:06Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 6 V +1 04/13/25, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77668
-
Benjamin Kott uploaded patch set 7
V +104/14/25, 07:04Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Benjamin Kott commented on patch set 7 CR -2 04/14/25, 07:06
Reply
Done -
core-ci voted on patch set 7 V +1 04/14/25, 07:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77686
-
Benjamin Kott uploaded patch set 8
V +104/14/25, 13:56Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Benjamin Kott voted on patch set 8 CR 0 04/14/25, 13:56
-
core-ci voted on patch set 8 V -1 04/14/25, 14:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77701
-
Benjamin Kott uploaded patch set 9
V -104/15/25, 08:02 -
core-ci voted on patch set 9 V +1 04/15/25, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77738
-
Andreas Kienast commented on patch set 9 CR -1 04/15/25, 09:26
on it -
Andreas Kienast uploaded patch set 10
CR -1V +104/15/25, 09:34 -
Andreas Kienast commented on patch set 10 04/15/25, 09:35
Reply
Done -
core-ci voted on patch set 10 V +1 04/15/25, 09:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77743
-
Benjamin Kott uploaded patch set 11
V +104/15/25, 12:25 -
Andreas Kienast voted on patch set 11 CR +1 V +1 04/15/25, 12:29
-
core-ci voted on patch set 11 V +1 04/15/25, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77755
-
Benjamin Kott voted on patch set 11 CR +2 V +2 04/15/25, 13:40
-
Benjamin Kott merged patch set 12 04/15/25, 13:49