Review main Merged

88889[TASK] Provide required attribute to example form

Georg Ringer CR +2 V +2 Easy +8 −4 updated 04/07/25, 19:11

Commit message

The example form which is used as predefined example should
also have the HTML attributes `required` to have a native
HTML validation.

NotEmpty validators are already provided for a server side validation.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • Stefan Froemken +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • Stefan Froemken +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Georg Ringer uploaded patch set 1 04/01/25, 18:06

  2. Georg Ringer commented on patch set 1 04/01/25, 18:06

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 04/01/25, 18:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76812

  4. Benni Mack updated the commit message in patch set 2 V +1 04/02/25, 05:57

  5. core-ci voted on patch set 2 V +1 04/02/25, 06:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76839

  6. Christian Kuhn voted on patch set 2 CR +1 V +1 04/07/25, 11:04

  7. Stefan Froemken commented on patch set 2 CR +1 V +1 04/07/25, 19:04

    Tested and verified. I filled in each field one by one and tested submit. For each field you get the message "Please fill this field". Perfect.
  8. Georg Ringer voted on patch set 2 CR +2 V +2 04/07/25, 19:11

  9. Georg Ringer merged patch set 3 04/07/25, 19:11