88891[BUGFIX] Fix f:form SelectViewHelper with wrong localized UID scheme
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Benni Mack +1
- core-ci +1 CI
Issues 5
- Bug #106494f:form.select ViewHelper cannot properly match combined identities
- Task #106493Add missing tests for extbase crud scenarios
- Task #87915Migrate TYPO3/CMS/Impexp/* to TypeScript
- Bug #105319Extbase domain model combined identity for localized entries
- Bug #59992Persistence session doesn't take overlays into account
Files 4
- typo3/sysext/core/Documentation/Changelog/13.4.x/Important-106494-AdaptInstancesOfAbstractFormFieldViewHelperDealingWithGetIdentifierByObject.rstnew+69 −0
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/BlogPostEditingControllerTest.php+0 −13
- typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php+9 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/SelectViewHelper.php+8 −0
Review log 1622
-
Garvin Hicking uploaded patch set 1 04/01/25, 19:38
-
core-ci voted on patch set 1 V +1 04/01/25, 19:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76815
-
Garvin Hicking commented on patch set 1 04/01/25, 19:54
HELP, please 😄 -
Garvin Hicking updated the commit message in patch set 2
V +104/02/25, 11:02 -
core-ci voted on patch set 2 V +1 04/02/25, 11:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76873
-
Stefan Bürk commented on patch set 2 04/02/25, 17:06
Reply
Provided Garvin in slack with a lot of examples and places as inspiration for tests ;). -
Garvin Hicking commented on patch set 2 04/02/25, 18:16
Reply
I think I'm on track for the tests, stay tuned ;) -
Stefan Bürk commented on patch set 2 CR -1 04/03/25, 08:43
-1 to wait for the tests (maybe make it wip for the time beeing @gh@faktor-e.de) -
Garvin Hicking marked it work in progress 04/03/25, 09:44
-
Garvin Hicking commented on patch set 2 04/03/25, 09:45
This change is ready for review.I marked it with [WIP] because I would like to keep the easy public visibility of this issue, if that's ok. -
Garvin Hicking commented on patch set 2 04/06/25, 18:09
Tests are now added to the related patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/88912?usp=search It contains uncommentable code that proves the bug which is fixed here will pass the test. I propose to first merge the test and then this. -
Simon Schaufelberger updated the commit message in patch set 3
CR -1V +104/07/25, 07:02 -
Simon Schaufelberger updated the commit message in patch set 4 04/07/25, 07:03
-
core-ci voted on patch set 3 V +1 04/07/25, 07:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77090
-
core-ci voted on patch set 4 V +1 04/07/25, 07:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77091
-
Garvin Hicking updated the commit message in patch set 5
V +104/07/25, 08:35 -
core-ci voted on patch set 5 V +1 04/07/25, 08:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77097
-
Garvin Hicking uploaded patch set 6
V +104/11/25, 12:23 -
core-ci voted on patch set 6 V +1 04/11/25, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77531
-
Benni Mack voted on patch set 6 CR +1 V +1 04/11/25, 14:52
-
Stefan Bürk voted on patch set 6 CR +2 V +2 04/12/25, 15:44
-
Stefan Bürk merged patch set 7 04/12/25, 15:52