Review main Merged

88892[TASK] Always use full row for loading foreign table items

Benni Mack CR +2 V +2 Normal +90 −36 updated 01/25/26, 12:33

Commit message

As part of the original work for speeding up
large categories, the full row loading magic is
now also included at any times, removing some special
handling code.

This was added back in 2022 via commit hash 971be9000b4
and has been proven stable until now.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 6

Files 4

Review log 1727

Show 12 earlier messages
  1. Benni Mack uploaded patch set 1 04/01/25, 19:38

  2. core-ci voted on patch set 1 V -1 04/01/25, 19:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76816

  1. Benni Mack uploaded patch set 2 V -1 04/01/25, 20:04

  2. core-ci voted on patch set 2 V -1 04/01/25, 20:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76818

  3. Benni Mack marked it work in progress 04/01/25, 21:30

  4. Benni Mack uploaded patch set 3 V -1 04/02/25, 14:42

  5. Benni Mack updated the commit message in patch set 4 04/02/25, 14:43

  6. Benni Mack marked it ready for review 04/02/25, 14:43

  7. core-ci voted on patch set 3 V -1 04/02/25, 14:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76897

  8. core-ci voted on patch set 4 V -1 04/02/25, 14:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76898

  9. Benni Mack uploaded patch set 5 V -1 04/07/25, 10:20

  10. core-ci voted on patch set 5 V -1 04/07/25, 10:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77110

  11. Benni Mack uploaded patch set 6 V -1 04/07/25, 19:55

  12. core-ci voted on patch set 6 V -1 04/07/25, 20:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77161

  13. Benni Mack marked it work in progress 04/08/25, 08:04

  14. Stefan Bürk uploaded patch set 7 V -1 04/24/25, 13:39

  15. core-ci voted on patch set 7 V +1 04/24/25, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78128

  16. Stefan Bürk uploaded patch set 8 V +1 04/25/25, 10:32

  17. core-ci voted on patch set 8 V -1 04/25/25, 10:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78177

  18. Stefan Bürk uploaded patch set 9 V -1 04/25/25, 11:01

  19. core-ci voted on patch set 9 V +1 04/25/25, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78178

  20. core-ci commented on patch set 9 04/25/25, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78179

  21. Benni Mack marked it ready for review 04/28/25, 19:25

  22. Stefan Bürk voted on patch set 9 CR +1 V +1 04/28/25, 19:35

  23. Georg Ringer voted on patch set 9 CR +2 V +2 04/28/25, 20:03

  24. Georg Ringer merged patch set 10 04/28/25, 20:03

  25. Markus Klein commented on patch set 10 01/25/26, 12:33

    This change most probably caused: https://forge.typo3.org/issues/108765