Review main Merged

88895[BUGFIX] Handle zero byte images in click enlarge gracefully

Georg Ringer CR +2 V +2 Easy +6 −2 updated 04/11/25, 17:15

Commit message

Use the public URL of files which happens if no cObj `IMG_RESOURCE`
could have been generated to avoid exceptions because a FileReference
can't be converted to a string.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Torben Hansen +1
  • Verified V +2 Done
    • Benni Mack +2
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Georg Ringer uploaded patch set 1 04/01/25, 21:07

  2. Georg Ringer commented on patch set 1 04/01/25, 21:08

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 04/01/25, 21:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76821

  4. Garvin Hicking commented on patch set 1 04/01/25, 21:40

    related, maybe we can address both?! https://review.typo3.org/c/Packages/TYPO3.CMS/+/88847
  5. Benni Mack abandoned the change 04/10/25, 09:30

    the mentioned code does not exist in v13 anymore.
  6. Benni Mack restored the change 04/11/25, 16:54

  7. Torben Hansen uploaded patch set 2 V +1 04/11/25, 16:56

  8. core-ci voted on patch set 2 V +1 04/11/25, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77563

  9. Torben Hansen voted on patch set 2 CR +1 V +1 04/11/25, 17:06

  10. Benni Mack commented on patch set 2 CR +2 V +2 04/11/25, 17:15

    Reply

    Done
    verified via TypoScript constants (had a wrong setting in site sets + wrong TypoScript record)
  11. Benni Mack merged patch set 3 04/11/25, 17:15