88898[BUGFIX] Use "allowed" option for TCA type=group in Extbase
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Christian Kuhn +1
- Stefan Froemken +1
-
Verified V +2 Done
- Georg Ringer +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 3
Files 2
Review log 1620
-
Benni Mack uploaded patch set 1 04/02/25, 07:12
-
core-ci voted on patch set 1 V -1 04/02/25, 07:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76844
-
Benjamin Franzke commented on patch set 1 CR -1 04/02/25, 07:24
We should adapt typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_post.php accordingly and thus cover this by tests. Do you by chance know why typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_tag.php (`tx_blogexample_domain_model_tag.items`) worked without `freign_table` setting? (I guess because of MM usage?) Will look into it. -
Garvin Hicking voted on patch set 1 CR +1 04/02/25, 07:28
-
Garvin Hicking voted on patch set 1 CR 0 04/02/25, 07:28
-
Stefan Froemken commented on patch set 1 CR -1 04/02/25, 07:47
ColumnMapFactory.php:75This is a little bit miss-leading. If multiple tables are configured in "allowed" or "prepend_tname" is activated you can of cause deal with multiple table relations. Maybe your comment is related to extbase ond the "foreign_table" option. Can you update the comment accordingly? Example: // TCA type="group" allows multiple tables via the "allowed" property. // However, Extbase DataMapper does not support resolving multi-table relations // stored in a single column (e.g., "pages_135,tt_content_7283"). // Therefore, only the first entry of "allowed" is used for Extbase compatibility. -
Benni Mack commented on patch set 1 04/02/25, 09:17
ColumnMapFactory.php:75ReplyStefan, feel free to adapt, you're more Extbase guru than me :) -
Benjamin Franzke uploaded patch set 2
CR -1V -104/02/25, 09:38 -
core-ci voted on patch set 2 V -1 04/02/25, 09:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76854
-
Benni Mack commented on patch set 2 04/02/25, 10:04
tx_blogexample_domain_model_post.php:79semantically, this is wrong. select needs foreign_table, "allowed" should be group -
Benni Mack commented on patch set 3
V -104/02/25, 10:04Published edit on patch set 2. -
core-ci voted on patch set 3 V -1 04/02/25, 10:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76857
-
Benjamin Franzke commented on patch set 3 04/02/25, 10:27
tx_blogexample_domain_model_post.php:79Replyuff, sorry, i thought this was `group` as well 🤦 -
Benjamin Franzke uploaded patch set 4
V -104/02/25, 10:36 -
Benjamin Franzke commented on patch set 4 04/02/25, 10:36
ColumnMapFactory.php:75Replyyes, so the basic issue is that extbase would need support for union types, right? Tried to adapt the comment.tx_blogexample_domain_model_post.php:79ReplyDone -
core-ci voted on patch set 4 V +1 04/02/25, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76863
-
Christian Kuhn voted on patch set 4 CR +1 V +1 04/07/25, 10:58
-
Stefan Froemken voted on patch set 4 CR +1 04/07/25, 19:50
-
Georg Ringer voted on patch set 4 CR +2 V +2 04/07/25, 19:52
-
Georg Ringer merged patch set 5 04/07/25, 19:52