88902[BUGFIX] Register global keydown handler to close modals
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 2
Review log 89
-
Andreas Kienast uploaded patch set 1 04/02/25, 08:21
-
core-ci voted on patch set 1 V +1 04/02/25, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76848
-
Garvin Hicking commented on patch set 1 04/02/25, 12:04
(mobile, just feedback) would this close a modal if I hit "esc" inside a form element within the modal to close auto-completion or an active select dropdown? (can test myself later) -
Andreas Kienast commented on patch set 1 04/02/25, 12:21
Reply
Yes, but that's IMO already the case with Bootstrap in place. -
Garvin Hicking commented on patch set 1 CR +1 V +1 04/03/25, 07:01
works for me, tried with a few modals and out-of-bound focussing, ESC reliably closes the modals for meReply
ack/confirmed, thanks! :) -
Garvin Hicking commented on patch set 1 04/03/25, 07:01
Reply
Done -
Christian Kuhn voted on patch set 1 CR +1 V +1 04/07/25, 10:43
-
Benni Mack voted on patch set 1 CR +2 V +2 04/07/25, 19:28
-
Benni Mack merged patch set 2 04/07/25, 19:28