Review main Merged

88903[TASK] Optimize appearance of form editor inspector

Josua Vogel CR +2 V +2 Hard +544 −382 updated 06/18/25, 12:50

Commit message

The width of the sidebar has been adjusted so that it is on a par with
the stage container. The PropertyGrid editor has also been expanded to
include card styling for small screens.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 2029

Show 34 earlier messages
  1. Josua Vogel uploaded patch set 1 04/02/25, 08:22

  2. core-ci voted on patch set 1 V +1 04/02/25, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76849

  3. Benjamin Kott commented on patch set 1 CR -2 04/03/25, 06:14

    -2 to ensure i review the change again. In it´s current form it cannot be merged. Next steps: 1. Remove custom table styling 2. Introduce inspector, width again (check if we can find a better value here) 3. Explore options to better make editable lists with collapsing behavior for small screen, ensure the component adapts to the surroundings (container queries) and not to the viewport.

    form.scss:81

    From my understanding, this patch is about the need to make the tables better editable. But this makes it way harder to edit the forms on large screens. Please consider extending the width of the inspector and not remove the limitation at all.

    form.scss:890

    This does not seem to be a proper solution. We are changing too much about the .table styling that just has been reversed so the universal styling can apply. We put in a lot of effort to get rid of overrides of components. They must be reusable without changes, otherwise they are worthless. I really would like to NOT change the table styling here at all. This makes it much harder to maintain the component. If we need a different kind of behavior here - we should move away from the .table to a custom markup for that section.
  4. Josua Vogel commented on patch set 1 04/03/25, 06:42

    form.scss:81 Reply

    So that I understand it better: To what extent is it more difficult on larger screens? The change only changes the width of the inspector. This results in longer input fields. The stage area will be smaller, but this is only for the visual display of the form and does not need the prominence it currently has due to its width for the tasks of an editor.

    form.scss:890 Reply

    I understand your opinion. Is there a mobile view in the revised table component without horizontal scrolling, where input fields in the table are rendered one below the other? I think this is best for the use case. Otherwise the inputs, e.g. e-mail addresses in the e-mail finisher, are barely legible. If not, a new component would be the best way.
  1. Josua Vogel uploaded patch set 2 V +1 04/15/25, 13:43

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  2. core-ci voted on patch set 2 V +1 04/15/25, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77764

  3. Josua Vogel uploaded patch set 3 V +1 05/21/25, 09:20

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  4. core-ci voted on patch set 3 V +1 05/21/25, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79285

  5. Josua Vogel uploaded patch set 4 V +1 05/28/25, 14:14

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  6. core-ci voted on patch set 4 V +1 05/28/25, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79646

  7. Benjamin Kott uploaded patch set 5 V +1 06/05/25, 11:53

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  8. Benjamin Kott commented on patch set 5 CR 0 06/05/25, 11:53

    form.scss:81 Reply

    Done

    form.scss:890 Reply

    Done
  9. core-ci voted on patch set 5 V -1 06/05/25, 12:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79924

  10. Benjamin Kott uploaded patch set 6 V -1 06/05/25, 12:08

  11. Benjamin Kott uploaded patch set 7 06/05/25, 12:10

  12. core-ci voted on patch set 6 V -1 06/05/25, 12:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79927

  13. core-ci voted on patch set 7 V +1 06/05/25, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79929

  14. Benni Mack voted on patch set 7 CR +1 06/05/25, 19:14

  15. Benjamin Franzke commented on patch set 7 06/06/25, 06:23

    form.scss:907

    Do we really need cascading here? Wouldn't `&__entries` suffice?

    property-grid-editor.ts:59

    labelValue, labelSelected and fieldLabels seem to be redundant. The former ones are actually unused.

    property-grid-editor.ts:104

    Let's use a lit `classMap()` here.

    property-grid-editor.ts:154

    Hm, this button allows dragging, cool! But it also allows focus on click, which does nothing. That's kinda irritating. If we really want this to be a button, we should probably switch into keyboard-controlled-move-mode as in the dashboard?

    inspector-component.ts:25

    This line is unneeded, since the line below creates an import as well (since it used `import { type` instead of `import type {…`).

    inspector-component.ts:1661

    We could switch the `if` and `else if` blocks, and avoid `!Array.isArray()` that way.

    inspector-component.ts:1673

    Maybe just use ``` for (const item of rawData) { ``` If it is an array, we do not need to use `in` + `hasOwnProperty` and therefore do not need to disable eslint rules. But note to myself: We need to check if an array mas misused as an indexed object here: ``` > const foo = ['test']; > foo.bar = 'baz'; // logs real array items and additional properties that have been added to the array > for (index in foo) { foo.hasOwnProperty(index) && console.log(foo[index]) } test baz // logs real array items only, ignores additional properties > for (item of foo) { console.log(item) } test ``` (if that's the case, the code MUST NOT be changed as I suggested)
  16. Benjamin Franzke uploaded patch set 8 CR +1 V +1 06/06/25, 08:24

  17. Benjamin Franzke commented on patch set 8 06/06/25, 08:24

    form.scss:907 Reply

    Done

    property-grid-editor.ts:59 Reply

    Done

    property-grid-editor.ts:104 Reply

    Done

    inspector-component.ts:25 Reply

    Done

    inspector-component.ts:1661 Reply

    Done

    inspector-component.ts:1673 Reply

    Done
  18. core-ci voted on patch set 8 V +1 06/06/25, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79973

  19. Benjamin Franzke uploaded patch set 9 V +1 06/06/25, 09:30

  20. Benjamin Franzke commented on patch set 9 06/06/25, 09:30

    property-grid-editor.ts:154 Reply

    I've added keyboard based ordering here, in order to fill this "button" with an appropriate functionality.
  21. core-ci voted on patch set 9 V +1 06/06/25, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79980

  22. Benjamin Kott voted on patch set 9 CR +2 V +2 06/06/25, 12:13

  23. Benjamin Kott merged patch set 10 06/06/25, 12:23

  24. Benni Mack commented on patch set 10 06/06/25, 13:23

    post +1 on testing
  25. Garvin Hicking commented on patch set 10 06/18/25, 12:50

    Please check out https://review.typo3.org/c/Packages/TYPO3.CMS/+/89756 and forge issue https://forge.typo3.org/issues/106907 for a (non-critical) regression on properly showing "unsaved changes" popup