Review main Abandoned

88906[TASK] Rework site configuration deletion

Andreas Kienast CR 0 V 0 Normal +203 −1 updated 11/19/25, 11:21

Commit message

With this patch, the site configuration folder now gets removed
if the site configation gets deleted via the Sites backend module, if
the directory is empty afterwards.

In case there are directories left without a site configuration, because
additional configuration files are in place (e.g. csp.yml), those
directories are now offered for deletion as well.

Additionally, the delete labels are now more explicit.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 7

Review log 2233

Show 68 earlier messages
  1. Andreas Kienast uploaded patch set 1 04/02/25, 10:10

  2. core-ci voted on patch set 1 V +1 04/02/25, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76858

  3. Benjamin Franzke commented on patch set 1 04/02/25, 10:18

    Things to consider: Inline file like settings.yaml, csp.yaml, setup.typoscript will all be lost. I think this is too implicit, if I only wanted to remove the configuration(?)
  4. Andreas Kienast commented on patch set 1 04/02/25, 12:48

    Reply

    I thought about this as well. One could argue that deleting a site configuration is a "strong" decision, OTOH it could be done accidentally.
  5. Andreas Kienast commented on patch set 1 V -1 04/03/25, 06:14

    I'll rework this area in general.
  6. Andreas Kienast uploaded patch set 2 V +1 04/03/25, 08:23

  7. Andreas Kienast commented on patch set 2 04/03/25, 08:25

    Reply

    Done

    Reply

    Done
  8. core-ci voted on patch set 2 V -1 04/03/25, 08:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76929

  1. Andreas Kienast uploaded patch set 3 V -1 04/03/25, 09:42

  2. core-ci voted on patch set 3 V +1 04/03/25, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76930

  3. Christian Kuhn commented on patch set 3 04/07/25, 10:37

    SiteConfigurationController.php:697

    typo 'No'

    SiteConfiguration.php:254

    to my experience, symfony finder can be quite slow when called often. with many matches, this finder loop may slow down rendering. we could keep it for now to see if big instances complain, so i'm leaving this just as a remark for now.
  4. Christian Kuhn commented on patch set 3 04/07/25, 10:38

    good to improve this, those empty dirs can be annoying.
  5. Andreas Kienast uploaded patch set 4 V +1 04/09/25, 06:05

  6. Andreas Kienast uploaded patch set 5 04/09/25, 06:05

  7. core-ci voted on patch set 4 V +1 04/09/25, 06:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77257

  8. core-ci voted on patch set 5 V +1 04/09/25, 06:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77258

  9. Andreas Kienast commented on patch set 5 04/09/25, 06:19

    SiteConfigurationController.php:697 Reply

    Done

    SiteConfiguration.php:254 Reply

    Done
  10. Andreas Kienast rebased onto patch set 6 V +1 04/11/25, 06:02

  11. core-ci voted on patch set 6 V -1 04/11/25, 06:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77493

  12. core-ci voted on patch set 6 V +1 04/11/25, 06:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77493

  13. Stefan Bürk commented on patch set 6 04/16/25, 08:04

    Love this in general, special the new listing of folders/files for site config folders without a site-configuration. Still, some questions/things which are not so optimal: * Currently, if one or more files/folders are not writable by the webserver/php process user, clicking the delete button will process the action silently saying nothing but keeping these files. At least we should make a notifcation that one or more files/foulds could not be deleted ? * It is not possible to delete only selected files, only all left-overs can be deleted. Not sure if that will raise some wishes in the future, and if that make sense. At least we should think about it and state when leaving it that way
  14. Andreas Kienast uploaded patch set 7 V +1 04/24/25, 10:40

  15. Andreas Kienast commented on patch set 7 04/24/25, 10:43

    Reply

    Deleting a directory now gives you a proper flash message. This is done differently here, as the existing messages are exception messages, which aren't localizable, but that's not the topic of this patch. Cherry-picking files for deletion isn't something I'd consider a use-case here. IMO it doesn't make sense to delete one single file from an invalid configuration directory. Also, allowing a user to delete files from valid configurations may cause severe issues which I'd like to avoid here.
  16. core-ci voted on patch set 7 V +1 04/24/25, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78112

  17. Andreas Kienast rebased onto patch set 8 V +1 04/28/25, 19:43

  18. core-ci voted on patch set 8 V +1 04/28/25, 19:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/78296

  19. Andreas Kienast rebased onto patch set 9 V +1 07/15/25, 09:49

  20. core-ci voted on patch set 9 V +1 07/15/25, 09:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81734

  21. Simon Schaufelberger voted on patch set 9 CR +1 07/17/25, 15:35

  22. Andreas Kienast rebased onto patch set 10 CR +1 V +1 11/14/25, 12:40

  23. core-ci voted on patch set 10 V +1 11/14/25, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/89688

  24. Lina Wolf commented on patch set 10 11/14/25, 14:52

    locallang_siteconfiguration.xlf:39 Unresolved

    If you introduce new language labels please write them in snake_case as was decided with the introduction of the new language domains: https://docs.typo3.org/permalink/t3contribute:appendix-cgl-xliff-reference
  25. Andreas Kienast abandoned the change 11/19/25, 11:21

    The patch is open for quite a while and I don't have time to rework it any further.