Review main Merged

88907[BUGFIX] Correctly process crop variants for imageLinkWrap

Thorben Nissen CR +2 V +2 Easy +13 −2 updated 10/02/26, 11:56

Commit message

When processing the configuration for the click-enlarge link, correctly
determine the crop area, to be used and write it into parameters and
conf for further processing.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1117

  1. Thorben Nissen uploaded patch set 1 04/02/25, 10:28

  2. core-ci voted on patch set 1 V -1 04/02/25, 10:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76862

  3. Thorben Nissen uploaded patch set 2 V -1 04/02/25, 11:43

  4. core-ci voted on patch set 2 V +1 04/02/25, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76879

  5. Garvin Hicking updated the commit message in patch set 3 V +1 04/02/25, 16:03

  6. core-ci voted on patch set 3 V +1 04/02/25, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76900

  7. Oliver Klee updated the commit message in patch set 4 V +1 04/02/25, 19:25

  8. core-ci voted on patch set 4 V +1 04/02/25, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76905

  9. Garvin Hicking commented on patch set 4 04/03/25, 05:12

    ideally when reviewing this we should also take a look at the related patches https://review.typo3.org/c/Packages/TYPO3.CMS/+/88847 https://review.typo3.org/c/Packages/TYPO3.CMS/+/88895

    ContentObjectRendererTest.php:1165

    where do these specific numbers come from?
  10. Garvin Hicking commented on patch set 4 04/03/25, 05:13

    Reply

    (unresolving)
  11. Benni Mack updated the commit message in patch set 5 V +1 04/22/26, 06:34

  12. core-ci voted on patch set 5 V -1 04/22/26, 07:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100740

  13. Benni Mack rebased onto patch set 6 V -1 09/09/26, 15:59

  14. core-ci voted on patch set 6 V +1 09/09/26, 16:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108204

  15. Garvin Hicking commented on patch set 6 CR +1 V +1 10/02/26, 11:11

    Reply

    Done

    ContentObjectRendererTest.php:1165 Reply

    Done
  16. Benni Mack voted on patch set 6 CR +2 V +2 10/02/26, 11:55

  17. Benni Mack merged patch set 7 10/02/26, 11:56