Review main Merged

88909[TASK] Mitigate phpstan issue early with `doctrine/dbal 4.3.x`

Stefan Bürk CR +2 V +2 Easy +2 −4 updated 04/02/25, 11:53

Commit message

Upcoming `doctrine/dbal 4.3.x` adds additional PHP DocBlocks to
narrow down array shapes and would be caught up by our nightlies
when the version is released.

`TYPO3\CMS\Core\Tests\Functional\Database\Schema\SchemaMigratorTest`
contains checks on the array representation of a `Column` explicitly
testing for the existence of the `default` key in the array, which
is already ensured since `doctrine/dbal 4.0.0`. Not providing any
value to be tested, array key checks are removed or replaced as small
early mitigation and preventing of failing nightly when the new version
is released.

Tested and extracted from `doctrine/dbal 4.3.x` test change,
see: https://review.typo3.org/c/Packages/TYPO3.CMS/+/88596

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 710

  1. Stefan Bürk uploaded patch set 1 04/02/25, 10:48

  2. Stefan Bürk updated the commit message in patch set 2 04/02/25, 10:49

  3. Andreas Kienast updated the commit message in patch set 3 04/02/25, 10:55

  4. core-ci voted on patch set 1 V +1 04/02/25, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76867

  5. core-ci voted on patch set 2 V +1 04/02/25, 10:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76868

  6. core-ci voted on patch set 3 V +1 04/02/25, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76870

  7. Georg Ringer voted on patch set 3 CR +1 V +1 04/02/25, 11:34

  8. Garvin Hicking voted on patch set 3 CR +1 V +1 04/02/25, 11:43

  9. Stefan Bürk voted on patch set 3 CR +2 V +2 04/02/25, 11:43

  10. Stefan Bürk merged patch set 4 04/02/25, 11:53