88912[TASK] Enhance blog_example extbase test with frontend editing
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Garvin Hicking +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 3
Files 20
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Controller/BlogPostEditingController.phpnew+97 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Blog.php2+9 −9
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Category.php+4 −7
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Comment.php+4 −10
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Post.php+9 −11
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/RestrictedComment.php+2 −4
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/TtContent.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Repository/CategoryRepository.phpnew+31 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Repository/PostRepository.php+14 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/Overrides/tt_content.php+6 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TypoScript/Frontend/setup.typoscriptnew+21 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TypoScript/setup.typoscript+2 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Private/Templates/BlogPostEditing/Edit.htmlnew+52 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Private/Templates/BlogPostEditing/List.htmlnew+19 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Private/Templates/BlogPostEditing/New.htmlnew+40 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Private/Templates/BlogPostEditing/View.htmlnew+6 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/ext_localconf.php+11 −0
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/BlogPostEditingData.csvnew+41 −0
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/BlogPostEditingControllerTest.phpnew+574 −0
- typo3/sysext/frontend/Tests/Functional/Request/InternalRequestDataMappingTest.php+24 −0
Review log 2842
Show 917 earlier messages
-
Garvin Hicking uploaded patch set 1 04/02/25, 10:59
-
Garvin Hicking updated the commit message in patch set 2 04/02/25, 11:03
-
core-ci voted on patch set 1 V +1 04/02/25, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76872
-
core-ci voted on patch set 2 V +1 04/02/25, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76874
-
Garvin Hicking uploaded patch set 3
V +104/03/25, 10:33 -
core-ci voted on patch set 3 V -1 04/03/25, 10:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76941
-
Garvin Hicking uploaded patch set 4
V -104/03/25, 11:17 -
core-ci voted on patch set 4 V -1 04/03/25, 11:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76946
-
Garvin Hicking uploaded patch set 5
V -104/03/25, 13:32 -
core-ci voted on patch set 5 V -1 04/03/25, 13:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76953
-
Garvin Hicking uploaded patch set 6
V -104/03/25, 16:43 -
core-ci voted on patch set 6 V -1 04/03/25, 16:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76958
-
Garvin Hicking uploaded patch set 7
V -104/03/25, 18:33 -
core-ci voted on patch set 7 V -1 04/03/25, 18:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76960
-
Garvin Hicking commented on patch set 8
V -104/03/25, 18:48Published edit on patch set 7. -
core-ci voted on patch set 8 V -1 04/03/25, 18:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76964
-
Garvin Hicking uploaded patch set 9
V -104/04/25, 11:03
-
core-ci voted on patch set 9 V +1 04/04/25, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77000
-
Georg Ringer commented on patch set 9 04/04/25, 11:43
FrontendEditingTest.php:81I suggest generating the chash on the fly, see https://review.typo3.org/c/Packages/TYPO3.CMS/+/87785/5/typo3/sysext/seo/Tests/Functional/XmlSitemap/AbstractXmlSitemapPagesTestCase.php -
Garvin Hicking commented on patch set 9 04/04/25, 12:18
FrontendEditingTest.php:81ReplyThere are multiple places for the chash on this test (its only most visible at this place) - I found many core tests that added this statically, I wonder if we would save performance here too? -
Garvin Hicking uploaded patch set 10
V +104/07/25, 07:35 -
Garvin Hicking commented on patch set 10 04/07/25, 07:36
FrontendEditingTest.php:81ReplyDone for the sake of it, feels cleaner. ;) -
core-ci voted on patch set 10 V +1 04/07/25, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77093
-
Garvin Hicking commented on patch set 10 CR -1 04/08/25, 08:11
I will rename "FrontendController" to "BlogPostEditingController" (thx benni) -
Garvin Hicking uploaded patch set 11
CR -1V +104/09/25, 09:38 -
Garvin Hicking uploaded patch set 12 04/09/25, 09:39
-
Garvin Hicking commented on patch set 12 04/09/25, 09:42
I've now updated this test: * Renamed to BlogPostEditing, renamed actions to Edit/New/Create/View * Added back-links to views * Added create+new actions * Created tests for create+new actions * Updated Extbase Annotations to Attributes * Inserted note to not use persisting examples for production -
Benni Mack commented on patch set 12 04/09/25, 09:47
PropertyMappingConfiguration.php:145do we want this fix to be included here? -
core-ci voted on patch set 11 V -1 04/09/25, 09:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77269
-
core-ci voted on patch set 12 V -1 04/09/25, 09:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77270
-
Garvin Hicking commented on patch set 12 04/09/25, 09:51
PropertyMappingConfiguration.php:145ReplyNo. I was hoping to get that fix (https://review.typo3.org/c/Packages/TYPO3.CMS/+/88942) in before we merge this test. Waiting for Stefan's feedback, he'll comment there. -
Garvin Hicking uploaded patch set 13
V -104/09/25, 09:51 -
core-ci voted on patch set 13 V +1 04/09/25, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77271
-
Garvin Hicking uploaded patch set 14
V +104/10/25, 07:29 -
Garvin Hicking commented on patch set 14 04/10/25, 07:29
PropertyMappingConfiguration.php:145ReplyChanged, now that patch 88942 has been merged -
core-ci voted on patch set 14 V +1 04/10/25, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77394
-
Benni Mack commented on patch set 14 04/10/25, 07:39
Blog.php:37do we need both validators? -
Garvin Hicking commented on patch set 14 04/10/25, 08:35
Blog.php:37ReplyFunnily yes. An empty string doesn't trigger "minimum 1"; I wanted to keep the earlier annotation for a maximum arround and think having a case for validator conjunctions would be good to have, too. -
Benni Mack voted on patch set 14 CR +1 V +1 04/10/25, 08:50
-
Stefan Bürk voted on patch set 14 CR +1 V +1 04/10/25, 09:23
-
Garvin Hicking voted on patch set 14 CR +2 V +2 04/10/25, 09:32
-
Garvin Hicking merged patch set 15 04/10/25, 10:40