Review main Merged

88912[TASK] Enhance blog_example extbase test with frontend editing

Garvin Hicking CR +2 V +2 Expert +968 −44 updated 04/10/25, 10:40

Commit message

Currently, the core has no functional test coverage of
basic "CRUD" forms using extbase:

* Listing of domain model records
* View details of single record
* Edit single record
* Save single record
* Create new record
* Utilize form validation

This is needed to also showcase localisation issues
and create future tests.

This test also reveals an issue with Guzzle's
`build()` method not supporting array with more
than 2 levels of depth. When needing this,
the `http_build_query` native PHP method can be
used, and a variant for this is added to
`InternalRequestDataMappingTest`.

This test also updates Extbase annotations.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 20

Review log 2842

Show 917 earlier messages
  1. Garvin Hicking uploaded patch set 1 04/02/25, 10:59

  2. Garvin Hicking updated the commit message in patch set 2 04/02/25, 11:03

  3. core-ci voted on patch set 1 V +1 04/02/25, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76872

  4. core-ci voted on patch set 2 V +1 04/02/25, 11:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76874

  5. Garvin Hicking uploaded patch set 3 V +1 04/03/25, 10:33

  6. core-ci voted on patch set 3 V -1 04/03/25, 10:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76941

  7. Garvin Hicking uploaded patch set 4 V -1 04/03/25, 11:17

  8. core-ci voted on patch set 4 V -1 04/03/25, 11:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76946

  9. Garvin Hicking uploaded patch set 5 V -1 04/03/25, 13:32

  10. core-ci voted on patch set 5 V -1 04/03/25, 13:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76953

  11. Garvin Hicking uploaded patch set 6 V -1 04/03/25, 16:43

  12. core-ci voted on patch set 6 V -1 04/03/25, 16:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76958

  13. Garvin Hicking uploaded patch set 7 V -1 04/03/25, 18:33

  14. core-ci voted on patch set 7 V -1 04/03/25, 18:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76960

  15. Garvin Hicking commented on patch set 8 V -1 04/03/25, 18:48

    Published edit on patch set 7.
  16. core-ci voted on patch set 8 V -1 04/03/25, 18:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76964

  17. Garvin Hicking uploaded patch set 9 V -1 04/04/25, 11:03

  1. core-ci voted on patch set 9 V +1 04/04/25, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77000

  2. Georg Ringer commented on patch set 9 04/04/25, 11:43

  3. Garvin Hicking commented on patch set 9 04/04/25, 12:18

    FrontendEditingTest.php:81 Reply

    There are multiple places for the chash on this test (its only most visible at this place) - I found many core tests that added this statically, I wonder if we would save performance here too?
  4. Garvin Hicking uploaded patch set 10 V +1 04/07/25, 07:35

  5. Garvin Hicking commented on patch set 10 04/07/25, 07:36

    FrontendEditingTest.php:81 Reply

    Done for the sake of it, feels cleaner. ;)
  6. core-ci voted on patch set 10 V +1 04/07/25, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77093

  7. Garvin Hicking commented on patch set 10 CR -1 04/08/25, 08:11

    I will rename "FrontendController" to "BlogPostEditingController" (thx benni)
  8. Garvin Hicking uploaded patch set 11 CR -1 V +1 04/09/25, 09:38

  9. Garvin Hicking uploaded patch set 12 04/09/25, 09:39

  10. Garvin Hicking commented on patch set 12 04/09/25, 09:42

    I've now updated this test: * Renamed to BlogPostEditing, renamed actions to Edit/New/Create/View * Added back-links to views * Added create+new actions * Created tests for create+new actions * Updated Extbase Annotations to Attributes * Inserted note to not use persisting examples for production
  11. Benni Mack commented on patch set 12 04/09/25, 09:47

    PropertyMappingConfiguration.php:145

    do we want this fix to be included here?
  12. core-ci voted on patch set 11 V -1 04/09/25, 09:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77269

  13. core-ci voted on patch set 12 V -1 04/09/25, 09:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77270

  14. Garvin Hicking commented on patch set 12 04/09/25, 09:51

    PropertyMappingConfiguration.php:145 Reply

    No. I was hoping to get that fix (https://review.typo3.org/c/Packages/TYPO3.CMS/+/88942) in before we merge this test. Waiting for Stefan's feedback, he'll comment there.
  15. Garvin Hicking uploaded patch set 13 V -1 04/09/25, 09:51

  16. core-ci voted on patch set 13 V +1 04/09/25, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77271

  17. Garvin Hicking uploaded patch set 14 V +1 04/10/25, 07:29

  18. Garvin Hicking commented on patch set 14 04/10/25, 07:29

    PropertyMappingConfiguration.php:145 Reply

    Changed, now that patch 88942 has been merged
  19. core-ci voted on patch set 14 V +1 04/10/25, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77394

  20. Benni Mack commented on patch set 14 04/10/25, 07:39

    Blog.php:37

    do we need both validators?
  21. Garvin Hicking commented on patch set 14 04/10/25, 08:35

    Blog.php:37 Reply

    Funnily yes. An empty string doesn't trigger "minimum 1"; I wanted to keep the earlier annotation for a maximum arround and think having a case for validator conjunctions would be good to have, too.
  22. Benni Mack voted on patch set 14 CR +1 V +1 04/10/25, 08:50

  23. Stefan Bürk voted on patch set 14 CR +1 V +1 04/10/25, 09:23

  24. Garvin Hicking voted on patch set 14 CR +2 V +2 04/10/25, 09:32

  25. Garvin Hicking merged patch set 15 04/10/25, 10:40