Review main Merged

88916[TASK] Prepare for a breaking `doctrine/dbal` deprecation

Stefan Bürk CR +2 V +2 Easy +28 −0 updated 04/03/25, 14:12

Commit message

Doctrine DBAL 4.3.x development branch contains a deprecation
breaking TYPO3 Database Analyzer handling [1], which has been
tested and reported as breaking [2].

While the discussion has been opened and the breaking behavior
may be mitigated, this change aims to prepare for the possible
case that this may not happen and having a solution in the next
TYPO3 release in place + the ability to use it as composer patch
for existing instances not being able to update to the version
including this mitigation code.

Note that the deprecation needs to be addressed in a bigger scope
to prepare for Doctrine DBAL 5.x upgrade which includes a rework
and reconception of the full `Database Analyzer` stack handling
and out of scope for now.

Tested and extracted from `doctrine/dbal 4.3.x` test change,
see: https://review.typo3.org/c/Packages/TYPO3.CMS/+/88596

[1] https://github.com/doctrine/dbal/pull/6831
[2] https://github.com/doctrine/dbal/issues/6880

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Stefan Bürk uploaded patch set 1 04/02/25, 11:57

  2. core-ci voted on patch set 1 V +1 04/02/25, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76881

  3. Oliver Klee updated the commit message in patch set 2 V +1 04/02/25, 12:30

  4. core-ci voted on patch set 2 V +1 04/02/25, 12:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76882

  5. Christian Kuhn voted on patch set 2 CR +1 V +1 04/03/25, 13:36

  6. Benni Mack voted on patch set 2 CR +1 V +1 04/03/25, 13:45

  7. Stefan Bürk voted on patch set 2 CR +2 V +2 04/03/25, 14:07

  8. Stefan Bürk merged patch set 3 04/03/25, 14:12