Review main Merged

88917[BUGFIX] Handle nullable type field in GridColumnItem->getTypeColumn

Nikita Hovratov CR +2 V +2 Easy +1 −1 updated 04/02/25, 13:47

Commit message

This may happen for a preview of records, which don't have a type field
configured. The behavior is restored from before the related patch,
where an empty string was returned.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Nikita Hovratov uploaded patch set 1 04/02/25, 13:06

  2. Andreas Kienast commented on patch set 1 CR +1 V +1 04/02/25, 13:07

    I was about to push the same patch.
  3. Nikita Hovratov commented on patch set 1 04/02/25, 13:08

    Reply

    gotta go fast!
  4. core-ci voted on patch set 1 V +1 04/02/25, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76883

  5. Oliver Klee voted on patch set 1 CR +1 04/02/25, 13:46

  6. Benni Mack voted on patch set 1 CR +2 V +2 04/02/25, 13:47

  7. Benni Mack merged patch set 2 04/02/25, 13:47