Review main Merged

88934[BUGFIX] DataHandler can modify soft-deleted records

Christian Kuhn CR +2 V +2 Normal +212 −1 updated 04/03/25, 13:17

Commit message

This slipped through with #106382: DataHandler fetches
records again in process_datamap() even if they are
soft-deleted to allow modification of such records.
An ext:content_defender functional test found this change
in behavior. The patch fixes this again adds tests.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 12

Review log 1014

  1. Christian Kuhn uploaded patch set 1 04/03/25, 10:04

  2. core-ci voted on patch set 1 V +1 04/03/25, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76934

  3. Christian Kuhn uploaded patch set 2 V +1 04/03/25, 10:45

  4. core-ci voted on patch set 2 V +1 04/03/25, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76943

  5. Christian Kuhn updated the commit message in patch set 3 V +1 04/03/25, 10:55

  6. Christian Kuhn updated the commit message in patch set 4 04/03/25, 10:56

  7. core-ci voted on patch set 4 V +1 04/03/25, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76945

  8. core-ci voted on patch set 3 V +1 04/03/25, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76944

  9. Benni Mack voted on patch set 4 CR +1 V +1 04/03/25, 11:22

  10. Stefan Bürk commented on patch set 4 CR -1 04/03/25, 11:37

    Reviewing ...
  11. Stefan Bürk voted on patch set 4 CR +1 V +1 04/03/25, 11:41

  12. Christian Kuhn commented on patch set 4 04/03/25, 12:39

    Reply

    Done
  13. Christian Kuhn voted on patch set 4 CR +2 V +2 04/03/25, 13:17

  14. Christian Kuhn merged patch set 5 04/03/25, 13:17