88946[FEATURE] Add events for getObjectCountByQuery
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-106510-AddedPSR-14EventsToExtbaseBackendgetObjectCountByQueryMethod.rst12new+44 −0
- typo3/sysext/extbase/Classes/Event/Persistence/ModifyQueryBeforeFetchingObjectCountEvent.phpnew+38 −0
- typo3/sysext/extbase/Classes/Event/Persistence/ModifyResultAfterFetchingObjectCountEvent.phpnew+43 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php+9 −1
Review log 1622
-
Markus Klein uploaded patch set 1 04/04/25, 11:36
-
core-ci voted on patch set 1 V +1 04/04/25, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77001
-
Johannes Kasberger voted on patch set 1 CR +1 V +1 04/04/25, 12:48
-
Markus Klein commented on patch set 1 CR -1 04/04/25, 12:54
Will be a feature. RST required -
Markus Klein uploaded patch set 2
CR +1V +104/04/25, 21:01 -
Markus Klein updated the commit message in patch set 3 04/04/25, 21:02
-
Markus Klein updated the commit message in patch set 4 04/04/25, 21:03
-
core-ci voted on patch set 2 V +1 04/04/25, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77016
-
core-ci voted on patch set 3 V +1 04/04/25, 21:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77017
-
core-ci voted on patch set 4 V +1 04/04/25, 21:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77018
-
Benni Mack voted on patch set 4 CR +1 V +1 04/05/25, 07:33
-
Garvin Hicking commented on patch set 4 04/05/25, 08:39
Feature-106510-AddedPSR-14EventsToExtbaseBackendgetObjectCountByQueryMethod.rst:14```suggestion The class :php:`TYPO3\CMS\Extbase\Persistence\Generic\Backend` is the covering entity to retrieve data from the database within the Extbase persistence framework. ```Feature-106510-AddedPSR-14EventsToExtbaseBackendgetObjectCountByQueryMethod.rst:16```suggestion Already in 2013 the :php:`getObjectDataByQuery` method got equipped with signals (later migrated to events) in order to modify data retrieval. ```Feature-106510-AddedPSR-14EventsToExtbaseBackendgetObjectCountByQueryMethod.rst:19```suggestion Extensions, or any other code using the existing events for data retrieval, have not been able to consistently modify queries, such that results returned by :php:`QueryResult` were consistent. ```Feature-106510-AddedPSR-14EventsToExtbaseBackendgetObjectCountByQueryMethod.rst:21```suggestion The :php:`getObjectCountByQuery` method is now enhanced with events as well. This finally allows extensions to modify all parts of query usage within Extbase's generic :php:`Backend` to achieve consistent results. ```Feature-106510-AddedPSR-14EventsToExtbaseBackendgetObjectCountByQueryMethod.rst:28```suggestion :php:`ModifyQueryBeforeFetchingObjectCountEvent` may be used to modify the query before being passed on to the actual storage backend. ```Feature-106510-AddedPSR-14EventsToExtbaseBackendgetObjectCountByQueryMethod.rst:30```suggestion :php:`ModifyResultAfterFetchingObjectCountEvent` may be used to adjust the result. ``` -
Johannes Kasberger voted on patch set 4 CR +1 V +1 04/07/25, 07:38
-
Garvin Hicking commented on patch set 5
CR +1V +104/09/25, 11:31Published edit on patch set 4. -
Garvin Hicking commented on patch set 5 04/09/25, 11:32
Feature-106510-AddedPSR-14EventsToExtbaseBackendgetObjectCountByQueryMethod.rst:14ReplyFix applied. -
core-ci voted on patch set 5 V +1 04/09/25, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77277
-
Markus Klein commented on patch set 5 04/09/25, 12:19
thx Garvin -
Garvin Hicking commented on patch set 6
V +104/09/25, 14:20Published edit on patch set 5. -
Garvin Hicking commented on patch set 6 CR +1 V +1 04/09/25, 14:21
(Note to self: Applying more than one gerrit suggestion at once doesn't seem possible. Had to apply manually now, finished.)Feature-106510-AddedPSR-14EventsToExtbaseBackendgetObjectCountByQueryMethod.rst:16ReplyDoneFeature-106510-AddedPSR-14EventsToExtbaseBackendgetObjectCountByQueryMethod.rst:19ReplyDoneFeature-106510-AddedPSR-14EventsToExtbaseBackendgetObjectCountByQueryMethod.rst:21ReplyDoneFeature-106510-AddedPSR-14EventsToExtbaseBackendgetObjectCountByQueryMethod.rst:28ReplyDoneFeature-106510-AddedPSR-14EventsToExtbaseBackendgetObjectCountByQueryMethod.rst:30ReplyDone -
core-ci voted on patch set 6 V +1 04/09/25, 14:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77287
-
Benni Mack voted on patch set 6 CR +2 V +2 04/09/25, 14:35
-
Benni Mack merged patch set 7 04/09/25, 14:35