Review main Merged Breaking

88949[!!!][TASK] Adapt FAL codebase - Part 2: Align PHP Interfaces

Benni Mack CR +2 V +2 Hard +144 −196 updated 04/08/25, 18:32

Commit message

In order to coordinate FAL code, this change
adapts FileInterface and FolderInterface as well as AbstractFile

- AbstractFile->rename()
- AbstractFile->copyTo()
- AbstractFile->moveTo()

are altogether moved to the File object, as this should not
be exposed to e.g. ProcessedFiles.

For this reason "FileInterface::rename()" is removed from
the FileInterface.

FolderInterface has more methods to implement now,
in order to allow interchangeability:
- FolderInterface::getSubFolder() returns a FolderInterface instance
- FolderInterface::getReadablePath() is added
- FolderInterface::getFiles() is added
- FolderInterface::searchFiles() is added
- FolderInterface::getRole() is added

Some calling code is adapted thanks to PHPstan.

Once this cleanup is done, more work on ResourceStorage is needed
to handle differentiation between File|ProcessedFile|null
as in getFileByIdentifier().

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 20

Review log 1014

  1. Benni Mack uploaded patch set 1 04/04/25, 18:03

  2. core-ci voted on patch set 1 V -1 04/04/25, 18:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77014

  3. Benni Mack uploaded patch set 2 V -1 04/06/25, 17:10

  4. core-ci voted on patch set 2 V +1 04/06/25, 17:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77069

  5. Benni Mack marked it work in progress 04/07/25, 17:26

  6. Benni Mack updated the commit message in patch set 3 V +1 04/08/25, 13:33

  7. core-ci voted on patch set 3 V +1 04/08/25, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77211

  8. Benni Mack uploaded patch set 4 V +1 04/08/25, 15:27

  9. Benni Mack marked it ready for review 04/08/25, 15:27

  10. core-ci voted on patch set 4 V +1 04/08/25, 15:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77214

  11. Christian Kuhn voted on patch set 4 CR +1 V +1 04/08/25, 18:21

  12. Georg Ringer voted on patch set 4 CR +2 V +2 04/08/25, 18:29

  13. Georg Ringer merged patch set 5 04/08/25, 18:29

  14. Stefan Bürk commented on patch set 5 04/08/25, 18:32

    post +1