Review 13.4 Merged

88962[BUGFIX] Avoid "Save changes and view" in FormEngine if form is invalid

Andreas Kienast CR +2 V +2 Normal +55 −26 updated 04/07/25, 13:20

Commit message

The implementation of the "Save changes and view" modal triggered in
FormEngine via the "View" button is prone to data inconsistency as it
may save the form and bypass the FormEngine validation.

The "View" modal now checks whether the current FormEngine state is
invalid and therefore won't render the "Save changes and view" button.

Please note: the bug cannot get triggered in TYPO3 v13+ "by accident"
due to underlying refactorings in the FormEngine done lately. However,
for UX reasons the same changes are implemented.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 2

Files 5

Review log 34

  1. Andreas Kienast uploaded patch set 1 04/07/25, 13:09

  2. core-ci voted on patch set 1 V +1 04/07/25, 13:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77133

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 04/07/25, 13:20

  4. Andreas Kienast merged patch set 2 04/07/25, 13:20