Review main Merged

88984[TASK] Improve DI in FAL StorageRepository

Christian Kuhn CR +2 V +2 Easy +12 −23 updated 04/08/25, 17:35

Commit message

There is no point in abstracting the main table name
away in StorageRepository since it is hard coded in
TCA for example. This makes the class more obviously
stateles. Also, ConnectionPool is injected.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 811

  1. Christian Kuhn uploaded patch set 1 04/08/25, 16:35

  2. core-ci voted on patch set 1 V -1 04/08/25, 16:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77216

  3. Christian Kuhn uploaded patch set 2 V -1 04/08/25, 16:42

  4. core-ci voted on patch set 2 V +1 04/08/25, 16:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77217

  5. Christian Kuhn updated the commit message in patch set 3 V +1 04/08/25, 16:56

  6. core-ci voted on patch set 3 V +1 04/08/25, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77218

  7. Benni Mack voted on patch set 3 CR +1 V +1 04/08/25, 17:11

  8. Andreas Nedbal voted on patch set 3 CR +1 V +1 04/08/25, 17:18

  9. Stefan Bürk voted on patch set 3 CR +1 V +1 04/08/25, 17:33

  10. Christian Kuhn voted on patch set 3 CR +2 V +2 04/08/25, 17:35

  11. Christian Kuhn merged patch set 4 04/08/25, 17:35