Review main Merged

88985[TASK] Avoid useless SingletonInterface in FlexFormService

Christian Kuhn CR +2 V +2 Normal +61 −83 updated 04/08/25, 18:27

Commit message

FlexFormService does not even have a constructor, implementing
SingletonInterface is useless. The patch removes this, adapts
DI of the service a bit and simplifies the unit tests.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 710

  1. Christian Kuhn uploaded patch set 1 04/08/25, 17:38

  2. core-ci voted on patch set 1 V -1 04/08/25, 17:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77219

  3. Christian Kuhn uploaded patch set 2 V -1 04/08/25, 17:52

  4. core-ci voted on patch set 2 V +1 04/08/25, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77222

  5. Christian Kuhn uploaded patch set 3 V +1 04/08/25, 18:00

  6. core-ci voted on patch set 3 V +1 04/08/25, 18:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77223

  7. Benni Mack voted on patch set 3 CR +1 V +1 04/08/25, 18:23

  8. Stefan Bürk voted on patch set 3 CR +1 V +1 04/08/25, 18:25

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 04/08/25, 18:27

  10. Christian Kuhn merged patch set 4 04/08/25, 18:27