88989[BUGFIX] Provide memcache object to close method
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1721
-
Georg Ringer uploaded patch set 1 04/08/25, 19:17
-
Georg Ringer commented on patch set 1 04/08/25, 19:17
This change is ready for review. -
Markus Klein voted on patch set 1 CR +1 V +1 04/08/25, 19:23
-
core-ci voted on patch set 1 V -1 04/08/25, 19:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77230
-
Stefan Bürk updated the commit message in patch set 2
CR +1V +104/08/25, 19:25 -
core-ci voted on patch set 2 V -1 04/08/25, 19:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77233
-
Georg Ringer commented on patch set 3
V -104/08/25, 19:56Published edit on patch set 2. -
core-ci voted on patch set 3 V +1 04/08/25, 20:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77235
-
Christian Kuhn voted on patch set 3 CR +1 V +1 04/08/25, 20:51
-
Markus Klein voted on patch set 3 CR +1 V +1 04/08/25, 20:54
-
Stefan Bürk voted on patch set 3 CR +2 V +2 04/08/25, 21:42
-
Stefan Bürk voted on patch set 3 CR 0 V 0 04/08/25, 21:43
-
Stefan Bürk commented on patch set 3 04/08/25, 21:47
ConfigurationStatus.php:169This silence phpstan totally for the next line. Should we not explicitly silence only the `arguments.count` reporting for the next line and keep eventually upcoming reportings working ... for example when the line gets moved out and $memcachedConnection is an incompatible type ? Stepped back ater adding the backport, so if others ack on this the backport needs updated after changing the main change. ```suggestion // @phpstan-ignore arguments.count ``` https://phpstan.org/user-guide/ignoring-errors#ignoring-in-code-using-phpdocs -
Stefan Bürk voted on patch set 3 CR -1 04/08/25, 21:51
-
Stefan Bürk commented on patch set 4
CR +1V +104/09/25, 07:03Published edit on patch set 3. -
Stefan Bürk commented on patch set 4 04/09/25, 07:05
ConfigurationStatus.php:169ReplyFix applied. -
core-ci voted on patch set 4 V +1 04/09/25, 07:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77260
-
Stefan Bürk voted on patch set 4 CR +1 V +1 04/09/25, 07:13
-
Benni Mack voted on patch set 4 CR +1 V +1 04/09/25, 09:15
-
Georg Ringer voted on patch set 4 CR +2 V +2 04/09/25, 09:15
-
Georg Ringer merged patch set 5 04/09/25, 09:15