Review main Merged

88994[TASK] Move `markFieldAsChanged()` to FormEngine main module

Andreas Kienast CR +2 V +2 Normal +118 −39 updated 04/27/25, 10:04

Commit message

The static method `markFieldAsChanged()` in the module
`@typo3/backend/form-engine-validation` is used to modify the markup in
the DOM to mark a field as changed. Technically, this is unrelated to
validation at all, therefore the method has been moved to
`@typo3/backend/form-engine`.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 23

Show 3 more files

Review log 810

  1. Andreas Kienast uploaded patch set 1 04/09/25, 09:21

  2. core-ci voted on patch set 1 V -1 04/09/25, 09:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77265

  3. Andreas Kienast uploaded patch set 2 V -1 04/09/25, 09:38

  4. core-ci voted on patch set 2 V +1 04/09/25, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77268

  5. Christian Kuhn voted on patch set 2 CR +1 V +1 04/09/25, 12:00

  6. Stefan Bürk voted on patch set 2 CR +1 04/09/25, 12:03

  7. Stefan Bürk voted on patch set 2 V +1 04/09/25, 12:03

  8. Andreas Kienast voted on patch set 2 CR +2 V +2 04/09/25, 12:08

  9. Andreas Kienast merged patch set 3 04/09/25, 12:08

  10. Lina Wolf commented on patch set 3 04/27/25, 10:04

    I am unsure if and where this needs to be documented. We dont really have anyone who knows about backend JavaScript in the documentation team: https://github.com/TYPO3-Documentation/Changelog-To-Doc/issues/1240