Review main Merged

89000[TASK] Clean up ext:impexp worker classes

Christian Kuhn CR +2 V +2 Hard +370 −396 updated 04/09/25, 15:38

Commit message

Classes ImportExport, Import and Export are still quite messy,
but we can do a few cleanups quite easily:

* Use inject* based DI in abstract ImportExport
* Use more DI in Import and Export
* Remove various unused get/set/is methods
* Inline a few properties
* Clean up a few comments / annotations
* Adapt tests as needed

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 710

  1. Christian Kuhn uploaded patch set 1 04/09/25, 13:17

  2. core-ci voted on patch set 1 V -1 04/09/25, 13:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77279

  3. Christian Kuhn uploaded patch set 2 V -1 04/09/25, 14:50

  4. core-ci voted on patch set 2 V -1 04/09/25, 14:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77291

  5. Christian Kuhn uploaded patch set 3 V -1 04/09/25, 15:10

  6. core-ci voted on patch set 3 V +1 04/09/25, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77293

  7. Stefan Bürk voted on patch set 3 CR +1 V +1 04/09/25, 15:32

  8. Benni Mack voted on patch set 3 CR +1 V +1 04/09/25, 15:35

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 04/09/25, 15:38

  10. Christian Kuhn merged patch set 4 04/09/25, 15:38