Review main Merged

89002[TASK] Abort field initialization early in FormEngine validation

Andreas Kienast CR +2 V +2 Easy +8 −6 updated 04/10/25, 08:44

Commit message

The FormEngine Validation module needs to initialize its input fields
before being able to validate them. This actions needs to be done in
case new fields are added, e.g. in IRRE. To avoid re-initializing
fields, a data attribute is set.

The code now checks early whether the data attribute is set to avoid
parsing JSON and querying the DOM which may not be needed at all.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Thomas Hohn +1
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Andreas Kienast uploaded patch set 1 04/09/25, 13:41

  2. Andreas Kienast uploaded patch set 2 04/09/25, 13:41

  3. core-ci voted on patch set 2 V +1 04/09/25, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77282

  4. Garvin Hicking voted on patch set 2 CR +1 V +1 04/10/25, 05:58

  5. Thomas Hohn voted on patch set 2 CR +1 04/10/25, 06:14

  6. Benni Mack voted on patch set 2 CR +1 V +1 04/10/25, 08:31

  7. Andreas Kienast voted on patch set 2 CR +2 V +2 04/10/25, 08:31

  8. Andreas Kienast merged patch set 3 04/10/25, 08:44