Review main Merged

89005[BUGFIX] Ensure SelectViewHelper uses strings for option*Field

Markus Klein CR +2 V +2 Easy +36 −2 updated 04/09/25, 15:43

Commit message

"optionValueField" and "optionLabelField" arguments need to be of type "string",
otherwise the call to `ObjectAccess::getPropertyPath` fails

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Simon Praetorius +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1113

  1. Markus Klein uploaded patch set 1 04/09/25, 14:36

  2. Markus Klein commented on patch set 1 CR -1 04/09/25, 14:41

    will add test
  3. core-ci voted on patch set 1 V +1 04/09/25, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77289

  4. Markus Klein uploaded patch set 2 CR -1 V +1 04/09/25, 14:45

  5. core-ci voted on patch set 2 V +1 04/09/25, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77290

  6. Simon Schaufelberger voted on patch set 2 CR +1 V +1 04/09/25, 14:51

  7. Stefan Bürk commented on patch set 2 04/09/25, 14:56

    This should be handled/fixed in fluid, but no easy solution. At least not without beeing breaking. https://github.com/TYPO3/Fluid/issues/1035
  8. Stefan Bürk voted on patch set 2 CR +1 V +1 04/09/25, 14:59

  9. Simon Praetorius voted on patch set 2 CR +1 04/09/25, 15:00

  10. Stefan Bürk commented on patch set 2 04/09/25, 15:01

    Reply

    Means: okay to fix this directly in VH meanwhile.
  11. Garvin Hicking voted on patch set 2 CR +1 V +1 04/09/25, 15:10

  12. Christian Kuhn voted on patch set 2 CR +2 V +2 04/09/25, 15:30

  13. Christian Kuhn merged patch set 3 04/09/25, 15:43