Review main Merged

89011[TASK] Raise --dev phpunit/phpunit:^11.5.17

Wouter Wolters CR +2 V +2 Normal +148 −92 updated 04/09/25, 19:01

Commit message

As a drive by change we change the deprecated function
isType towards its alternative. This is a preparation for PHPunit 12

> composer req nikic/php-parser:^5.4.0
> composer require -d typo3/sysext/install --no-update \
    "nikic/php-parser":"^5.4.0"
> composer req --dev phpunit/phpunit:^11.5.17 -w

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 812

  1. Wouter Wolters uploaded patch set 1 04/09/25, 17:26

  2. core-ci voted on patch set 1 V -1 04/09/25, 17:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77302

  3. Wouter Wolters uploaded patch set 2 V -1 04/09/25, 17:52

  4. core-ci voted on patch set 2 V -1 04/09/25, 17:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77303

  5. Wouter Wolters uploaded patch set 3 V -1 04/09/25, 18:02

  6. core-ci voted on patch set 3 V +1 04/09/25, 18:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77305

  7. Benni Mack voted on patch set 3 CR +1 V +1 04/09/25, 18:12

  8. Christian Kuhn commented on patch set 3 CR -1 04/09/25, 18:19

    temp -1: backport pushed, will run nightly on both.
  9. Stefan Bürk voted on patch set 3 CR +1 V +1 04/09/25, 18:21

  10. core-ci commented on patch set 3 04/09/25, 18:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77309

  11. Christian Kuhn voted on patch set 3 CR +2 V +2 04/09/25, 19:01

  12. Christian Kuhn merged patch set 4 04/09/25, 19:01