Review 13.4 Merged

89013[BUGFIX] Fix missing version number of files from custom backend modules

Benni Mack CR +2 V +2 Normal +63 −15 updated 04/09/25, 19:15

Commit message

When using the asset renderer API, Backend assets did not
get cached-busted due to a "bug" in the calling order of
methods in AssetRenderer but also due to a misleading if()
statement if a already used /my-path/myfile.css was included
in BE.

This is now changed and documented properly.

The calling order should always be:

   # make a file reference completely absolute
   1. $file = GeneralUtility::getFileAbsFileName($file);

   # attach ?timestamp to filename
   2. $file = GeneralUtility::createVersionNumberedFilename($file);

   # make it ready for attaching in your HTML/JSON etc.
   3. $file = PathUtility::getAbsoluteWebPath($file);

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 4

Files 6

Review log 34

  1. Benni Mack commented on patch set 1 04/09/25, 18:24

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 04/09/25, 18:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77311

  3. Benni Mack voted on patch set 1 CR +2 V +2 04/09/25, 19:15

  4. Benni Mack merged patch set 2 04/09/25, 19:15